Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(create-next-app): remove stub types definition #25139

Merged
merged 3 commits into from May 16, 2021
Merged

chore(create-next-app): remove stub types definition #25139

merged 3 commits into from May 16, 2021

Conversation

jamesgeorge007
Copy link
Contributor

@types/next is a stub types definition.

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label May 14, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented May 16, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
buildDuration 13.4s 13.2s -166ms
buildDurationCached 4.2s 4.1s -63ms
nodeModulesSize 46.7 MB 46.7 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.202 2.261 ⚠️ +0.06
/ avg req/sec 1135.41 1105.5 ⚠️ -29.91
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.17 1.134 -0.04
/error-in-render avg req/sec 2137.58 2204.63 +67.05
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
index.html gzip 560 B 560 B ✓
link.html gzip 569 B 569 B ✓
withRouter.html gzip 557 B 557 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode (Decrease detected ✓)
General
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
buildDuration 16.8s 16.5s -244ms
buildDurationCached 5.9s 6.2s ⚠️ +255ms
nodeModulesSize 46.7 MB 46.7 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
_error.js 1.34 MB 1.34 MB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 1.34 MB 1.34 MB ✓
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.4 MB 1.4 MB -2 B
withRouter.js 1.4 MB 1.4 MB ✓
Overall change 6.91 MB 6.91 MB -2 B
Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
buildDuration 11.4s 11.5s ⚠️ +54ms
buildDurationCached 4.9s 4.6s -248ms
nodeModulesSize 46.7 MB 46.7 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.278 2.284 ⚠️ +0.01
/ avg req/sec 1097.3 1094.78 ⚠️ -2.52
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.189 1.203 ⚠️ +0.01
/error-in-render avg req/sec 2102.47 2078.68 ⚠️ -23.79
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.26 kB 7.26 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.38 kB 9.38 kB ✓
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js create-next-app-ts Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: ffc3746

@kodiakhq kodiakhq bot merged commit 9b27d31 into vercel:canary May 16, 2021
@jamesgeorge007 jamesgeorge007 deleted the create-next-app-ts branch May 16, 2021 05:37
@jamesgeorge007 jamesgeorge007 changed the title chore(create-next-app): remove stub type definitions chore(create-next-app): remove stub types definition May 16, 2021
This was referenced May 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced May 20, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Open
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@jamesgeorge007
chore(create-next-app): remove stub type definitions (vercel#25139)
fe0a17c 
[@types/next](https://www.npmjs.com/package/@types/next) is a stub types definition.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamesgeorge007 @ijjk @timneutkens