Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure server split chunks are nested in chunks dir #25203

Merged
merged 1 commit into from
May 17, 2021
Merged

Ensure server split chunks are nested in chunks dir #25203

merged 1 commit into from
May 17, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 17, 2021

Follow-up to #25035 this ensures the split chunks are nested in the .next/server/chunks directory which ensures tracing succeeds successfully when deployed.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member Author

ijjk commented May 17, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/server-chunks Change
buildDuration 15.4s 15.8s ⚠️ +412ms
buildDurationCached 4.7s 4.4s -298ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +193 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/server-chunks Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.648 2.732 ⚠️ +0.08
/ avg req/sec 944.1 915.22 ⚠️ -28.88
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.539 1.587 ⚠️ +0.05
/error-in-render avg req/sec 1624.75 1574.88 ⚠️ -49.87
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/server-chunks Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/server-chunks Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/server-chunks Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/server-chunks Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/server-chunks Change
index.html gzip 561 B 561 B ✓
link.html gzip 570 B 570 B ✓
withRouter.html gzip 558 B 558 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/server-chunks Change
buildDuration 18.3s 18s -390ms
buildDurationCached 5.6s 5.5s -124ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +193 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/server-chunks Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/server-chunks Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/server-chunks Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/server-chunks Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/server-chunks Change
_error.js 16.9 kB 17 kB ⚠️ +74 B
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 17.2 kB 17.3 kB ⚠️ +74 B
link.js 17.4 kB 17.6 kB ⚠️ +132 B
routerDirect.js 17.4 kB 17.5 kB ⚠️ +132 B
withRouter.js 17.4 kB 17.6 kB ⚠️ +132 B
Overall change 107 kB 108 kB ⚠️ +544 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/server-chunks Change
buildDuration 13.2s 13s -148ms
buildDurationCached 5.5s 5.4s -70ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +193 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/server-chunks Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.628 2.791 ⚠️ +0.16
/ avg req/sec 951.45 895.65 ⚠️ -55.8
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.557 1.592 ⚠️ +0.04
/error-in-render avg req/sec 1605.37 1570.32 ⚠️ -35.05
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/server-chunks Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.26 kB 7.26 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/server-chunks Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/server-chunks Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.38 kB 9.38 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/server-chunks Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/server-chunks Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 09bdf5a

@ijjk ijjk merged commit 9c6d7bb into vercel:canary May 17, 2021
@ijjk ijjk deleted the update/server-chunks branch May 17, 2021 20:24
This was referenced May 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced May 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@ijjk
Ensure server split chunks are nested in chunks dir (vercel#25203)
f2721ca
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @sokra