Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazy load postcss plugins #25317

Merged
merged 1 commit into from May 21, 2021
Merged

lazy load postcss plugins #25317

merged 1 commit into from May 21, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented May 20, 2021

Improves startup performance

for vercel/front by ~1s

@ijjk
Copy link
Member

ijjk commented May 20, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
buildDuration 11.5s 11.8s ⚠️ +281ms
buildDurationCached 3.6s 3.2s -332ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +1.5 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.093 2.043 -0.05
/ avg req/sec 1194.67 1223.89 +29.22
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.113 1.076 -0.04
/error-in-render avg req/sec 2245.95 2323.64 +77.69
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
index.html gzip 559 B 559 B ✓
link.html gzip 567 B 567 B ✓
withRouter.html gzip 555 B 555 B ✓
Overall change 1.68 kB 1.68 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
buildDuration 13.8s 13.7s -104ms
buildDurationCached 4.4s 4.1s -240ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +1.5 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB ✓
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
buildDuration 10.5s 10.8s ⚠️ +275ms
buildDurationCached 4.6s 4.4s -156ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +1.5 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.129 2.117 -0.01
/ avg req/sec 1174 1180.98 +6.98
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.122 1.081 -0.04
/error-in-render avg req/sec 2227.35 2311.82 +84.47
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.25 kB 7.25 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.38 kB 9.38 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js perf/lazy-postcss-plugins Change
index.html gzip 613 B 613 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: aee72b6

@kodiakhq kodiakhq bot merged commit 7035a03 into canary May 21, 2021
@kodiakhq kodiakhq bot deleted the perf/lazy-postcss-plugins branch May 21, 2021 00:31
@sync-by-unito sync-by-unito bot mentioned this pull request May 26, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@sokra
lazy load postcss plugins (vercel#25317)
ee0bc9c 
Improves startup performance

for vercel/front by ~1s
This was referenced Jul 29, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 19, 2021
Open
This was referenced Jan 12, 2022
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sokra @ijjk