Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font optimization add preconnect #25346

Merged
merged 5 commits into from Jun 2, 2021
Merged

Font optimization add preconnect #25346

merged 5 commits into from Jun 2, 2021

Conversation

janicklas-ralph
Copy link
Contributor

Bug

Adds preconnect tag with optimizeFonts is enabled
Fixes #24872

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jun 1, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js font Change
buildDuration 11.5s 11.5s -39ms
buildDurationCached 3.3s 3.3s -18ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +2.97 kB
Page Load Tests Overall increase ✓
vercel/next.js canary janicklas-ralph/next.js font Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.021 2.026 0
/ avg req/sec 1236.78 1233.72 ⚠️ -3.06
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.113 1.059 -0.05
/error-in-render avg req/sec 2246.6 2361.06 +114.46
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js font Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js font Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary janicklas-ralph/next.js font Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.53 kB 8.53 kB ✓
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js font Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary janicklas-ralph/next.js font Change
index.html gzip 561 B 561 B ✓
link.html gzip 569 B 569 B ✓
withRouter.html gzip 557 B 557 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js font Change
buildDuration 13.4s 13.6s ⚠️ +197ms
buildDurationCached 4.1s 4s -156ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +2.97 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js font Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js font Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary janicklas-ralph/next.js font Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.53 kB 8.53 kB ✓
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js font Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js font Change
_error.js 16.9 kB 16.9 kB ⚠️ +2 B
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ⚠️ +34 B
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB ⚠️ +36 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary janicklas-ralph/next.js font Change
buildDuration 10.5s 10.6s ⚠️ +124ms
buildDurationCached 4.6s 4.3s -321ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +2.97 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary janicklas-ralph/next.js font Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.148 2.129 -0.02
/ avg req/sec 1163.61 1174.19 +10.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.093 1.117 ⚠️ +0.02
/error-in-render avg req/sec 2286.89 2239.08 ⚠️ -47.81
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js font Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.26 kB 7.26 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js font Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary janicklas-ralph/next.js font Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.37 kB 9.37 kB ✓
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js font Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary janicklas-ralph/next.js font Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 4e47952

@timneutkens timneutkens merged commit 58a4482 into vercel:canary Jun 2, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 16, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
@janicklas-ralph
Font optimization add preconnect (vercel#25346)
eb3c3f9
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Font optimization - Typekit font loaded twice
3 participants
@janicklas-ralph @ijjk @timneutkens