Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing i18n types in gip context #25363

Merged
merged 1 commit into from May 22, 2021
Merged

Add missing i18n types in gip context #25363

merged 1 commit into from May 22, 2021

Conversation

rokinsky
Copy link
Contributor

@rokinsky rokinsky commented May 22, 2021 •
edited

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • [] Make sure the linting passes

Ref: #21930

@rokinsky rokinsky mentioned this pull request May 22, 2021
Merged
@ijjk
Copy link
Member

ijjk commented May 22, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
buildDuration 15.9s 15.9s -36ms
buildDurationCached 4.5s 4.3s -166ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +431 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.846 2.845 0
/ avg req/sec 878.31 878.85 +0.54
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.652 1.762 ⚠️ +0.11
/error-in-render avg req/sec 1513.44 1418.45 ⚠️ -94.99
Client Bundles (main, webpack, commons)
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
index.html gzip 559 B 559 B ✓
link.html gzip 567 B 567 B ✓
withRouter.html gzip 555 B 555 B ✓
Overall change 1.68 kB 1.68 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
buildDuration 18.2s 18.2s ⚠️ +26ms
buildDurationCached 5.5s 5.5s -72ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +431 B
Client Bundles (main, webpack, commons)
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB ✓
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
buildDuration 14.1s 13.8s -320ms
buildDurationCached 5.9s 5.7s -172ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +431 B
Page Load Tests Overall increase ✓
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.94 2.794 -0.15
/ avg req/sec 850.28 894.84 +44.56
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.697 1.681 -0.02
/error-in-render avg req/sec 1472.89 1486.84 +13.95
Client Bundles (main, webpack, commons)
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.25 kB 7.25 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.38 kB 9.38 kB ✓
Client Build Manifests
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary rokinsky/next.js buxfix/gip-i18n-types Change
index.html gzip 613 B 613 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: c7d4b5e

timneutkens
timneutkens approved these changes May 22, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an integration test to test/integration/typescript?

@kodiakhq kodiakhq bot merged commit 48cbb81 into vercel:canary May 22, 2021
@rokinsky
Copy link
Contributor Author

Can you add an integration test to test/integration/typescript?

@timneutkens I'll try to add the test next week

@rokinsky rokinsky deleted the buxfix/gip-i18n-types branch May 22, 2021 16:39
@sync-by-unito sync-by-unito bot mentioned this pull request May 26, 2021
Closed
@rokinsky
Copy link
Contributor Author

Hi, @timneutkens. In my opinion, test/integration/typescript is not the right place for this, so we have to create a separate test/integration/typescript-i18n where we should check the SSG, SSR, GiP, and router for i18n types. What do you think?

@timneutkens
Copy link
Member

Sounds fine 👍

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@rokinsky
Add missing i18n types in gip context (vercel#25363)
50f4af8 
## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [] Make sure the linting passes

Ref: vercel#21930
This was referenced Jul 29, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 19, 2021
Open
This was referenced Jan 12, 2022
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rokinsky @ijjk @timneutkens