Modify image component examples app for static image #25956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atcastle
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
leerob
approved these changes
Jun 9, 2021
styfle
reviewed
Jun 9, 2021
| @@ -1,30 +1,26 @@ | |||
| import Image from 'next/image' | |||
| import ViewSource from '../components/view-source' | |||
| import mountains from '../public/mountains.jpg' | |||
There was a problem hiding this comment.
Do we want to use lowercase or should we use uppercase to match other imports?
There was a problem hiding this comment.
Lowercase is correct, uppercase is for React components
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 16, 2021
Some fairly minor changes to the image-component example app. Switches all instances of images from `/public` over to use static images and adds a page with an example image with blurry placeholder enabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fairly minor changes to the image-component example app. Switches all instances of images from
/publicover to use static images and adds a page with an example image with blurry placeholder enabled.