[ESLint] Remove error when file patterns are unmatched + ESLint setup changes #27119

housseindjirdeh · 2021-07-12T18:05:35Z

This PR does the following:

Disables the errorOnUnmatchedPattern property for ESLint to not error when file patterns are unmatched (examples: empty directory, directory ignored in .eslintignore). Both next lint and next build are updated. Closes next lint does not work with src directory #26155
Deletes conformance integration tests that are outdated and rely on the old webpack conformance plugin
Includes a new test/.eslintrc.json file to configure ESLint specifically for test files
Updates failing test cases where which were failing with the new test/.eslintrc.json config
Removed .eslintignore for test/integration/async-modules (ported from Remove webpack 4 support #26915)
Added support for top level await to Next.js eslint preset (ported from Remove webpack 4 support #26915)

ijjk · 2021-07-13T20:10:26Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
buildDuration	11.8s	11.8s	⚠️ +46ms
buildDurationCached	2.8s	2.7s	-68ms
nodeModulesSize	49.3 MB	49.3 MB	⚠️ +253 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.826	1.807	-0.02
/ avg req/sec	1369.32	1383.24	+13.92
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.04	1.039	0
/error-in-render avg req/sec	2403.23	2406.19	+2.96

Client Bundles (main, webpack, commons)

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
359.HASH.js gzip	3.09 kB	3.09 kB	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	20.9 kB	20.9 kB	✓
webpack-HASH.js gzip	1.49 kB	1.49 kB	✓
Overall change	67.6 kB	67.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
_app-HASH.js gzip	803 B	803 B	✓
_error-HASH.js gzip	3.18 kB	3.18 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	329 B	329 B	✓
hooks-HASH.js gzip	903 B	903 B	✓
image-HASH.js gzip	5.69 kB	5.69 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	319 B	319 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
_buildManifest.js gzip	419 B	419 B	✓
Overall change	419 B	419 B	✓

Rendered Page Sizes

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	524 B	524 B	✓
Overall change	1.6 kB	1.6 kB	✓

Webpack 4 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
buildDuration	9.4s	9.5s	⚠️ +51ms
buildDurationCached	3.7s	3.7s	-29ms
nodeModulesSize	49.3 MB	49.3 MB	⚠️ +253 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.933	1.995	⚠️ +0.06
/ avg req/sec	1293.42	1252.96	⚠️ -40.46
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.015	1.045	⚠️ +0.03
/error-in-render avg req/sec	2463.76	2393.17	⚠️ -70.59

Client Bundles (main, webpack, commons)

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
14.HASH.js gzip	3.11 kB	3.11 kB	✓
677f882d2ed8..HASH.js gzip	13.9 kB	13.9 kB	✓
framework.HASH.js gzip	41.8 kB	41.8 kB	✓
main-HASH.js gzip	8.17 kB	8.17 kB	✓
webpack-HASH.js gzip	1.19 kB	1.19 kB	✓
Overall change	68.1 kB	68.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
_app-HASH.js gzip	791 B	791 B	✓
_error-HASH.js gzip	3.83 kB	3.83 kB	✓
amp-HASH.js gzip	531 B	531 B	✓
css-HASH.js gzip	333 B	333 B	✓
hooks-HASH.js gzip	910 B	910 B	✓
index-HASH.js gzip	230 B	230 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	297 B	297 B	✓
withRouter-HASH.js gzip	293 B	293 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	8.98 kB	8.98 kB	✓

Client Build Manifests

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
_buildManifest.js gzip	418 B	418 B	✓
Overall change	418 B	418 B	✓

Rendered Page Sizes

	vercel/next.js canary	housseindjirdeh/next.js bug/26155	Change
index.html gzip	574 B	574 B	✓
link.html gzip	585 B	585 B	✓
withRouter.html gzip	568 B	568 B	✓
Overall change	1.73 kB	1.73 kB	✓

Commit: f09a6ce

ijjk · 2021-07-13T20:22:25Z

Failing test suites

Commit: f09a6ce

test/acceptance/ReactRefreshLogBox.dev.test.js

server-side only compilation errors

Expand output

● server-side only compilation errors

ScriptTimeoutError: script timeout
  (Session info: headless chrome=91.0.4472.114)

  72 |
  73 |             // Wait for application to re-hydrate:
> 74 |             await browser.executeAsyncScript(function () {
     |             ^
  75 |               var callback = arguments[arguments.length - 1]
  76 |               if (window.__NEXT_HYDRATED) {
  77 |                 callback()

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
      at runMicrotasks (<anonymous>)
  at Proxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.patch (acceptance/helpers.js:74:13)
  at Object.<anonymous> (acceptance/ReactRefreshLogBox.dev.test.js:1415:3)

.eslintignore

packages/next/cli/next-lint.ts

test/.eslintrc.json

timneutkens

Looks great, thanks for fixing/porting these @housseindjirdeh 💯

… changes (vercel#27119) Co-authored-by: Tim Neutkens <tim@timneutkens.nl>

housseindjirdeh requested review from huozhi, ijjk, padmaia, shuding, styfle and timneutkens as code owners July 12, 2021 18:05

ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Jul 12, 2021

This comment has been minimized.

Sign in to view

housseindjirdeh mentioned this pull request Jul 12, 2021

Remove webpack 4 support #26915

Closed

11 tasks

This comment has been minimized.

Sign in to view

housseindjirdeh marked this pull request as draft July 12, 2021 20:13

This comment has been minimized.

Sign in to view

ijjk added the examples Issue/PR related to examples label Jul 13, 2021

This comment has been minimized.

Sign in to view

fixes error on unmatched flag, updates eslint setup within next.js repo

f09a6ce

housseindjirdeh marked this pull request as ready for review July 13, 2021 22:05

housseindjirdeh requested review from leerob and lfades as code owners July 13, 2021 22:05

housseindjirdeh changed the title ~~[ESLint] Remove error when file patterns are unmatched~~ [ESLint] Remove error when file patterns are unmatched + ESLint setup changes Jul 13, 2021

housseindjirdeh commented Jul 13, 2021

View reviewed changes

.eslintignore Show resolved Hide resolved

housseindjirdeh commented Jul 13, 2021

View reviewed changes

packages/next/cli/next-lint.ts Show resolved Hide resolved

housseindjirdeh commented Jul 13, 2021

View reviewed changes

test/.eslintrc.json Show resolved Hide resolved

housseindjirdeh mentioned this pull request Jul 14, 2021

next lint does not work with src directory #26155

Closed

timneutkens approved these changes Jul 16, 2021

View reviewed changes

Merge branch 'canary' into bug/26155

82aa38a

timneutkens merged commit 6645248 into vercel:canary Jul 16, 2021

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021

[ESLint] Remove error when file patterns are unmatched + ESLint setup…

c54a7a7

… changes (vercel#27119) Co-authored-by: Tim Neutkens <tim@timneutkens.nl>

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ESLint] Remove error when file patterns are unmatched + ESLint setup changes #27119

[ESLint] Remove error when file patterns are unmatched + ESLint setup changes #27119

housseindjirdeh commented Jul 12, 2021 •

edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jul 13, 2021

ijjk commented Jul 13, 2021

timneutkens left a comment

[ESLint] Remove error when file patterns are unmatched + ESLint setup changes #27119

[ESLint] Remove error when file patterns are unmatched + ESLint setup changes #27119

Conversation

housseindjirdeh commented Jul 12, 2021 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jul 13, 2021

Stats from current PR

ijjk commented Jul 13, 2021

Failing test suites

timneutkens left a comment

Choose a reason for hiding this comment

housseindjirdeh commented Jul 12, 2021 •

edited