Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional stats app pages #27202

Merged
merged 3 commits into from Jul 16, 2021
Merged

Add additional stats app pages #27202

merged 3 commits into from Jul 16, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 15, 2021

This adds pages to the stats-app to track next/script, next/dynamic, and next/head

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Jul 15, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Jul 16, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
buildDuration 15.5s 15.8s ⚠️ +279ms
buildDurationCached 3.5s 3.7s ⚠️ +236ms
nodeModulesSize 49.5 MB 49.5 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
/ failed reqs 0 0
/ total time (seconds) 2.595 2.653 ⚠️ +0.06
/ avg req/sec 963.27 942.5 ⚠️ -20.77
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.689 1.58 -0.11
/error-in-render avg req/sec 1480.51 1582.65 +102.14
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
359.HASH.js gzip 2.96 kB 2.96 kB
745.HASH.js gzip 180 B 180 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 20.9 kB 20.9 kB
webpack-HASH.js gzip 1.53 kB 1.53 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 554 B 554 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 2.28 kB 2.28 kB
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.6 kB 5.6 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.1 kB 19.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
_buildManifest.js gzip 489 B 489 B
Overall change 489 B 489 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
buildDuration 12.6s 13.5s ⚠️ +841ms
buildDurationCached 5.2s 5.2s ⚠️ +37ms
nodeModulesSize 49.5 MB 49.5 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
/ failed reqs 0 0
/ total time (seconds) 2.793 2.832 ⚠️ +0.04
/ avg req/sec 895.11 882.81 ⚠️ -12.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.727 1.674 -0.05
/error-in-render avg req/sec 1447.64 1493.79 +46.15
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
17.HASH.js gzip 2.98 kB 2.98 kB
18.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 13.7 kB 13.7 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 8.39 kB 8.39 kB
webpack-HASH.js gzip 1.22 kB 1.22 kB
Overall change 68.4 kB 68.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.76 kB 3.76 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.02 kB 3.02 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.6 kB 17.6 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
_buildManifest.js gzip 499 B 499 B
Overall change 499 B 499 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/more-stats-pages Change
index.html gzip 577 B 577 B
link.html gzip 588 B 588 B
withRouter.html gzip 569 B 569 B
Overall change 1.73 kB 1.73 kB
Commit: 23c6fdb

@ijjk
Copy link
Member Author

ijjk commented Jul 16, 2021

Failing test suites

Commit: 23c6fdb

test/integration/basepath/test/index.test.js

  • basePath development > Hot Module Reloading > editing a page > should update styles correctly
Expand output

● basePath development › Hot Module Reloading › editing a page › should update styles correctly

TIMED OUT: /200px/

100px

  399 |
  400 |   if (hardError) {
> 401 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  402 |   }
  403 |   return false
  404 | }

  at check (lib/next-test-utils.js:401:11)
  at Object.<anonymous> (integration/basepath/test/index.test.js:242:15)

@ijjk ijjk merged commit 4b1bf75 into vercel:canary Jul 16, 2021
@ijjk ijjk deleted the add/more-stats-pages branch July 16, 2021 17:13
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants