Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Drop react-is dependency in styled-components example (#27527)" #27543

Merged
merged 1 commit into from Jul 27, 2021
Merged

Revert "Drop react-is dependency in styled-components example (#27527)" #27543

merged 1 commit into from Jul 27, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 27, 2021

This reverts commit 317c1c4.

It looks like this change caused the yarn pnp tests to fail so this re-adds it.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team examples Issue/PR related to examples labels Jul 27, 2021
shuding
shuding approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test passes now 🎉

@ijjk ijjk marked this pull request as ready for review July 27, 2021 19:34
@ijjk ijjk merged commit b0f516d into vercel:canary Jul 27, 2021
@ijjk ijjk deleted the revert/styled-component-change branch July 27, 2021 19:35
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@ijjk
Revert "Drop react-is dependency in styled-components example (vercel…
ac7508e 
…#27527)" (vercel#27543)

This reverts commit 317c1c4.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@shuding shuding shuding approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@padmaia padmaia Awaiting requested review from padmaia

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @styfle @shuding