Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render as a concatenation of streams #28082

Merged
merged 3 commits into from Aug 13, 2021
Merged

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Aug 13, 2021

Return the RenderResult as a concatenation of streams, rather than a concatenation of strings.

@ijjk ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Aug 13, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 13, 2021

Failing test suites

Commit: 1afd091

test/integration/amphtml-custom-optimizer/test/index.test.js

  • AMP Custom Optimizer > should build and start for static page
  • AMP Custom Optimizer > should build and start for dynamic page
Expand output

● AMP Custom Optimizer › should build and start for static page

command failed with code 1

  157 |         code !== 0
  158 |       ) {
> 159 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  160 |       }
  161 |
  162 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:159:23)

● AMP Custom Optimizer › should build and start for dynamic page

command failed with code 1

  157 |         code !== 0
  158 |       ) {
> 159 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  160 |       }
  161 |
  162 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:159:23)

test/integration/amphtml-fragment-style/test/index.test.js

  • AMP Fragment Styles > adds styles from fragment in AMP mode correctly
Expand output

● AMP Fragment Styles › adds styles from fragment in AMP mode correctly

command failed with code 1

  157 |         code !== 0
  158 |       ) {
> 159 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  160 |       }
  161 |
  162 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:159:23)

● Test suite failed to run

TypeError: Cannot read property '__app' of undefined

  346 |
  347 | export async function stopApp(server) {
> 348 |   if (server.__app) {
      |              ^
  349 |     await server.__app.close()
  350 |   }
  351 |   await promiseCall(server, 'close')

  at stopApp (lib/next-test-utils.js:348:14)
  at integration/amphtml-fragment-style/test/index.test.js:32:18

test/integration/amphtml-custom-validator/test/index.test.js

  • AMP Custom Validator > should build and start successfully
  • AMP Custom Validator > should run in dev mode successfully
Expand output

● AMP Custom Validator › should build and start successfully

command failed with code 1

  157 |         code !== 0
  158 |       ) {
> 159 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  160 |       }
  161 |
  162 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:159:23)

● AMP Custom Validator › should run in dev mode successfully

expect(received).toContain(expected) // indexOf

Expected substring: "Hello from AMP"
Received string:    "<!DOCTYPE html><!DOCTYPE html><html><head><style data-next-hide-fouc=\"true\">body{display:none}</style><noscript data-next-hide-fouc=\"true\"><style>body{display:block}</style></noscript><meta charSet=\"utf-8\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta name=\"next-head-count\" content=\"2\"/><noscript data-n-css=\"\"></noscript><script defer=\"\" nomodule=\"\" src=\"/_next/static/chunks/polyfills.js?ts=1628869218707\"></script><script src=\"/_next/static/chunks/webpack.js?ts=1628869218707\" defer=\"\"></script><script src=\"/_next/static/chunks/main.js?ts=1628869218707\" defer=\"\"></script><script src=\"/_next/static/chunks/pages/_app.js?ts=1628869218707\" defer=\"\"></script><script src=\"/_next/static/chunks/pages/_error.js?ts=1628869218707\" defer=\"\"></script><script src=\"/_next/static/development/_buildManifest.js?ts=1628869218707\" defer=\"\"></script><script src=\"/_next/static/development/_ssgManifest.js?ts=1628869218707\" defer=\"\"></script><noscript id=\"__next_css__DO_NOT_USE__\"></noscript></head><body><div id=\"__next\"></div><script src=\"/_next/static/chunks/react-refresh.js?ts=1628869218707\"></script><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"statusCode\":500}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"development\",\"isFallback\":false,\"err\":{\"name\":\"TypeError\",\"message\":\"Cannot read property 'replace' of undefined\",\"stack\":\"TypeError: Cannot read property 'replace' of undefined\\n    at /home/runner/work/next.js/next.js/packages/next/dist/server/render.js:766:25\\n    at Object.renderToHTML (/home/runner/work/next.js/next.js/packages/next/dist/server/render.js:773:30)\\n    at processTicksAndRejections (internal/process/task_queues.js:95:5)\\n    at async doRender (/home/runner/work/next.js/next.js/packages/next/dist/server/next-server.js:1133:38)\\n    at async /home/runner/work/next.js/next.js/packages/next/dist/server/next-server.js:1227:28\\n    at async /home/runner/work/next.js/next.js/packages/next/dist/server/response-cache.js:60:36\"},\"gip\":true,\"scriptLoader\":[]}</script></body></html>"

  45 |
  46 |     expect(stderr).not.toContain('error')
> 47 |     expect(html).toContain('Hello from AMP')
     |                  ^
  48 |   })
  49 | })
  50 |

  at Object.<anonymous> (integration/amphtml-custom-validator/test/index.test.js:47:18)

@ijjk
Copy link
Member

ijjk commented Aug 13, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
buildDuration 12.5s 12.5s -32ms
buildDurationCached 2.9s 2.9s -34ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +6.93 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
/ failed reqs 0 0
/ total time (seconds) 2.27 2.344 ⚠️ +0.07
/ avg req/sec 1101.52 1066.61 ⚠️ -34.91
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.264 1.266 0
/error-in-render avg req/sec 1977.78 1974.85 ⚠️ -2.93
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
index.html gzip 531 B 533 B ⚠️ +2 B
link.html gzip 544 B 546 B ⚠️ +2 B
withRouter.html gzip 524 B 525 B ⚠️ +1 B
Overall change 1.6 kB 1.6 kB ⚠️ +5 B

Diffs

Diff for index.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!DOCTYPE html>
 <html>
   <head>
     <meta charset="utf-8" />
Diff for link.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!DOCTYPE html>
 <html>
   <head>
     <meta charset="utf-8" />
Diff for withRouter.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!DOCTYPE html>
 <html>
   <head>
     <meta charset="utf-8" />

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
buildDuration 10.3s 10.4s ⚠️ +89ms
buildDurationCached 4.1s 4s -54ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +6.93 kB
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
/ failed reqs 0 0
/ total time (seconds) 2.323 2.317 -0.01
/ avg req/sec 1076.4 1078.93 +2.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.277 1.266 -0.01
/error-in-render avg req/sec 1957.76 1974.8 +17.04
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-chunked-body-new Change
index.html gzip 577 B 578 B ⚠️ +1 B
link.html gzip 589 B 591 B ⚠️ +2 B
withRouter.html gzip 569 B 570 B ⚠️ +1 B
Overall change 1.74 kB 1.74 kB ⚠️ +4 B

Diffs

Diff for index.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!DOCTYPE html>
 <html>
   <head>
     <meta charset="utf-8" />
Diff for link.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!DOCTYPE html>
 <html>
   <head>
     <meta charset="utf-8" />
Diff for withRouter.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!DOCTYPE html>
 <html>
   <head>
     <meta charset="utf-8" />
Commit: c811f7a

@devknoll devknoll marked this pull request as ready for review Aug 13, 2021
@kodiakhq kodiakhq bot merged commit d2551bb into vercel:canary Aug 13, 2021
31 checks passed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants