Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wrong link error message #28127

Merged
merged 2 commits into from Aug 15, 2021
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Aug 15, 2021

Fixes: #28126

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

shuding
shuding previously approved these changes Aug 15, 2021
@ijjk
Copy link
Member

ijjk commented Aug 15, 2021

Failing test suites

Commit: 5d1dd0b

test/integration/link-ref/test/index.test.js

  • Invalid hrefs > dev mode > should not show error for class component as child of next/link
  • Invalid hrefs > production mode > should not have a race condition with a click handler
  • Invalid hrefs > production mode > should preload with forwardRef
  • Invalid hrefs > production mode > should preload with child ref with React.createRef
  • Invalid hrefs > production mode > should preload with child ref with function
Expand output

● Invalid hrefs › dev mode › should not show error for class component as child of next/link

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  30 |   await waitFor(1000)
  31 |   const numErrors = await browser.eval(`window.caughtErrors.length`)
> 32 |   expect(numErrors).toBe(0)
     |                     ^
  33 |   await browser.close()
  34 | }
  35 |

  at noError (integration/link-ref/test/index.test.js:32:21)
  at Object.<anonymous> (integration/link-ref/test/index.test.js:76:7)

● Invalid hrefs › production mode › should not have a race condition with a click handler

command failed with code 1

  157 |         code !== 0
  158 |       ) {
> 159 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  160 |       }
  161 |
  162 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:159:23)

● Invalid hrefs › production mode › should preload with forwardRef

command failed with code 1

  157 |         code !== 0
  158 |       ) {
> 159 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  160 |       }
  161 |
  162 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:159:23)

● Invalid hrefs › production mode › should preload with child ref with React.createRef

command failed with code 1

  157 |         code !== 0
  158 |       ) {
> 159 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  160 |       }
  161 |
  162 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:159:23)

● Invalid hrefs › production mode › should preload with child ref with function

command failed with code 1

  157 |         code !== 0
  158 |       ) {
> 159 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  160 |       }
  161 |
  162 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:159:23)

@ijjk
Copy link
Member

ijjk commented Aug 15, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/link-error-message Change
buildDuration 12.2s 12.5s ⚠️ +311ms
buildDurationCached 3s 3.2s ⚠️ +140ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +2 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/link-error-message Change
/ failed reqs 0 0
/ total time (seconds) 2.439 2.596 ⚠️ +0.16
/ avg req/sec 1025.08 963.06 ⚠️ -62.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.351 1.381 ⚠️ +0.03
/error-in-render avg req/sec 1850.94 1810.09 ⚠️ -40.85
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/link-error-message Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/link-error-message Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/link-error-message Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.64 kB 2.64 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/link-error-message Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/link-error-message Change
index.html gzip 540 B 540 B
link.html gzip 552 B 552 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/link-error-message Change
buildDuration 9.9s 10.4s ⚠️ +487ms
buildDurationCached 4.2s 4.2s -18ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +2 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/link-error-message Change
/ failed reqs 0 0
/ total time (seconds) 2.506 2.476 -0.03
/ avg req/sec 997.6 1009.75 +12.15
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.371 1.387 ⚠️ +0.02
/error-in-render avg req/sec 1823.4 1802.85 ⚠️ -20.55
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/link-error-message Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/link-error-message Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/link-error-message Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.83 kB 2.83 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.8 kB 17.8 kB
Client Build Manifests Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/link-error-message Change
_buildManifest.js gzip 497 B 498 B ⚠️ +1 B
Overall change 497 B 498 B ⚠️ +1 B
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary huozhi/next.js fix/link-error-message Change
index.html gzip 585 B 585 B
link.html gzip 598 B 597 B -1 B
withRouter.html gzip 579 B 579 B
Overall change 1.76 kB 1.76 kB -1 B

Diffs

Diff for _buildManifest.js
@@ -16,7 +16,7 @@ self.__BUILD_MANIFEST = {
   "/hooks": [
     "static\u002Fchunks\u002Fpages\u002Fhooks-f3d7a61f2e1bf307c8a9.js"
   ],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-2bc441b40fdd53a8f46a.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-42cb0e3f9b432b6fb0f9.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-6969fe7df87ea0f513b7.js"
   ],
Diff for link.html
@@ -31,7 +31,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-2bc441b40fdd53a8f46a.js"
+      src="/_next/static/chunks/pages/link-42cb0e3f9b432b6fb0f9.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Commit: 50a28c6

@huozhi huozhi requested a review from shuding Aug 15, 2021
@kodiakhq kodiakhq bot merged commit 4cdb585 into vercel:canary Aug 15, 2021
32 checks passed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
@huozhi huozhi deleted the fix/link-error-message branch Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error when rendering Error page link
3 participants