Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade webpack to 5.51.1 #28291

Merged
merged 2 commits into from Aug 19, 2021
Merged

upgrade webpack to 5.51.1 #28291

merged 2 commits into from Aug 19, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Aug 19, 2021

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 19, 2021
@sokra sokra marked this pull request as draft Aug 19, 2021
@ijjk

This comment has been minimized.

@sokra sokra marked this pull request as ready for review Aug 19, 2021
@sokra sokra changed the title upgrade webpack to 5.51.0 upgrade webpack to 5.51.1 Aug 19, 2021
huozhi
huozhi approved these changes Aug 19, 2021
@ijjk
Copy link
Member

ijjk commented Aug 19, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
buildDuration 16.9s 15.6s -1.3s
buildDurationCached 3.9s 4.3s ⚠️ +385ms
nodeModulesSize 61.4 MB 61.4 MB ⚠️ +17.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
/ failed reqs 0 0
/ total time (seconds) 3.053 3.091 ⚠️ +0.04
/ avg req/sec 818.87 808.8 ⚠️ -10.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.892 1.903 ⚠️ +0.01
/error-in-render avg req/sec 1321.43 1313.79 ⚠️ -7.64
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.2 kB 23.2 kB
webpack-HASH.js gzip 1.44 kB 1.45 kB ⚠️ +14 B
Overall change 67.1 kB 67.1 kB ⚠️ +14 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/update Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/update Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/update Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
index.html gzip 539 B 540 B ⚠️ +1 B
link.html gzip 550 B 552 B ⚠️ +2 B
withRouter.html gzip 532 B 533 B ⚠️ +1 B
Overall change 1.62 kB 1.63 kB ⚠️ +4 B

Diffs

Diff for _buildManifest.js
@@ -14,7 +14,7 @@ self.__BUILD_MANIFEST = {
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-1b407c3309821b5154c2.js"],
   "/hooks": [
-    "static\u002Fchunks\u002Fpages\u002Fhooks-d386c05297cfdcd36f03.js"
+    "static\u002Fchunks\u002Fpages\u002Fhooks-f6efb8a484d4a96e150c.js"
   ],
   "/image": [
     "static\u002Fchunks\u002Fpages\u002Fimage-474b709f83960ad881c7.js"
Diff for hooks-HASH.js
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [757],
   {
-    /***/ 9976: /***/ function(
+    /***/ 3626: /***/ function(
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -144,7 +144,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/hooks",
         function() {
-          return __webpack_require__(9976);
+          return __webpack_require__(3626);
         }
       ]);
Diff for webpack-HASH.js
@@ -391,14 +391,21 @@
       /******/ /******/ /******/ var moduleId,
         chunkId,
         i = 0;
-      /******/ for (moduleId in moreModules) {
-        /******/ if (__webpack_require__.o(moreModules, moduleId)) {
-          /******/ __webpack_require__.m[moduleId] = moreModules[moduleId];
+      /******/ if (
+        chunkIds.some(function(id) {
+          return installedChunks[id] !== 0;
+        })
+      ) {
+        /******/ for (moduleId in moreModules) {
+          /******/ if (__webpack_require__.o(moreModules, moduleId)) {
+            /******/ __webpack_require__.m[moduleId] = moreModules[moduleId];
+            /******/
+          }
           /******/
         }
+        /******/ if (runtime) var result = runtime(__webpack_require__);
         /******/
       }
-      /******/ if (runtime) var result = runtime(__webpack_require__);
       /******/ if (parentChunkLoadingFunction) parentChunkLoadingFunction(data);
       /******/ for (; i < chunkIds.length; i++) {
         /******/ chunkId = chunkIds[i];
Diff for index.html
@@ -11,7 +11,7 @@
       src="/_next/static/chunks/polyfills-a40ef1678bae11e696dba45124eadd70.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-47f60bc5ff0cf5dfe268.js"
+      src="/_next/static/chunks/webpack-e3a4ea5707671df28cf0.js"
       defer=""
     ></script>
     <script
Diff for link.html
@@ -11,7 +11,7 @@
       src="/_next/static/chunks/polyfills-a40ef1678bae11e696dba45124eadd70.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-47f60bc5ff0cf5dfe268.js"
+      src="/_next/static/chunks/webpack-e3a4ea5707671df28cf0.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html
@@ -11,7 +11,7 @@
       src="/_next/static/chunks/polyfills-a40ef1678bae11e696dba45124eadd70.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-47f60bc5ff0cf5dfe268.js"
+      src="/_next/static/chunks/webpack-e3a4ea5707671df28cf0.js"
       defer=""
     ></script>
     <script

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
buildDuration 14s 13.8s -200ms
buildDurationCached 5.5s 5.4s -108ms
nodeModulesSize 61.4 MB 61.4 MB ⚠️ +17.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
/ failed reqs 0 0
/ total time (seconds) 3.27 3.198 -0.07
/ avg req/sec 764.52 781.83 +17.31
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.88 1.967 ⚠️ +0.09
/error-in-render avg req/sec 1330.14 1271.09 ⚠️ -59.05
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/update Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/update Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/update Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.98 kB 2.98 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/update Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/update Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 3a19357

ijjk
ijjk approved these changes Aug 19, 2021
styfle
styfle approved these changes Aug 19, 2021
@kodiakhq kodiakhq bot merged commit 426d732 into canary Aug 19, 2021
33 checks passed
@kodiakhq kodiakhq bot deleted the webpack/update branch Aug 19, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants