Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(with-sentry example): Small tweaks #28359

Merged
merged 7 commits into from Sep 17, 2021
Merged

fix(with-sentry example): Small tweaks #28359

merged 7 commits into from Sep 17, 2021

Conversation

lobsterkatie
Copy link
Contributor

@lobsterkatie lobsterkatie commented Aug 20, 2021 •
edited

This PR makes two changes:

  • It updates the index page to reflect the fact that withSentry should now be working for API routes deployed to Vercel.
  • It changes the route which returns a promise rejection to be more obvious about the fact that that's what it's doing.

@ijjk ijjk added the examples Issue/PR related to examples label Aug 20, 2021
@lobsterkatie lobsterkatie mentioned this pull request Sep 8, 2021
Merged
10 tasks
@kodiakhq kodiakhq bot merged commit cee1565 into vercel:canary Sep 17, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lobsterkatie @leerob @ijjk