Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure @babel/core is de-duped when nccing #28384

Merged
merged 5 commits into from Aug 22, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 21, 2021

This ensures @babel/core is de-duped correctly in the ncc'd babel packages by separating the ncc steps for @babel/core and the babel packages so that @babel/core can be marked as an external to the ncc'd output correctly. This fixes an OOM error that was occurring while running the test/unit/next-babel-loader.unit.test.js test on macOS after upgrading the babel packages in #28174

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 21, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Aug 22, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
buildDuration 16.1s 17.1s ⚠️ +985ms
buildDurationCached 8.3s 3.7s -4.6s
nodeModulesSize 61.5 MB 61.7 MB ⚠️ +249 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
/ failed reqs 0 0
/ total time (seconds) 2.865 2.951 ⚠️ +0.09
/ avg req/sec 872.49 847.29 ⚠️ -25.2
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.696 1.701 ⚠️ +0.01
/error-in-render avg req/sec 1473.99 1469.6 ⚠️ -4.39
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
buildDuration 13.8s 13.8s -19ms
buildDurationCached 5.7s 5.6s -82ms
nodeModulesSize 61.5 MB 61.7 MB ⚠️ +249 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
/ failed reqs 0 0
/ total time (seconds) 2.936 2.98 ⚠️ +0.04
/ avg req/sec 851.54 838.94 ⚠️ -12.6
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.648 1.657 ⚠️ +0.01
/error-in-render avg req/sec 1516.67 1508.47 ⚠️ -8.2
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3 kB 3 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
_buildManifest.js gzip 501 B 501 B
Overall change 501 B 501 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/babel-nccing Change
index.html gzip 586 B 586 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 533a8b5

@ijjk ijjk marked this pull request as ready for review Aug 22, 2021
styfle
styfle approved these changes Aug 22, 2021
@ijjk ijjk merged commit 83209a4 into vercel:canary Aug 22, 2021
32 checks passed
@ijjk ijjk deleted the fix/babel-nccing branch Aug 22, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants