Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should allow nullable param for res.end #28694

Merged
merged 2 commits into from Sep 1, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Sep 1, 2021

Bug

Fixes #28693

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Sep 1, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/override-send Change
buildDuration 12.9s 12.8s -72ms
buildDurationCached 2.9s 2.9s -8ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +24 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix/override-send Change
/ failed reqs 0 0
/ total time (seconds) 2.292 2.272 -0.02
/ avg req/sec 1090.98 1100.36 +9.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.277 1.279 0
/error-in-render avg req/sec 1957.14 1954.78 ⚠️ -2.36
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/override-send Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/override-send Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/override-send Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/override-send Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/override-send Change
index.html gzip 540 B 540 B
link.html gzip 552 B 552 B
withRouter.html gzip 533 B 533 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/override-send Change
buildDuration 10.6s 10.5s -123ms
buildDurationCached 4.5s 4.5s -25ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +24 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix/override-send Change
/ failed reqs 0 0
/ total time (seconds) 2.34 2.327 -0.01
/ avg req/sec 1068.28 1074.18 +5.9
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.273 1.27 0
/error-in-render avg req/sec 1963.21 1968.71 +5.5
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/override-send Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.7 kB 10.7 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68.1 kB 68.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/override-send Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/override-send Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/override-send Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/override-send Change
index.html gzip 586 B 586 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 946e909

@kodiakhq kodiakhq bot merged commit ed9b886 into vercel:canary Sep 1, 2021
@huozhi huozhi deleted the fix/override-send branch September 1, 2021 17:03
@mariohmol
Copy link

Hi there!! Thanks for it!

Getting this error in production, I made this change directly on node_modules and it worked!!

Can you tell me when this will be released?

thanks!

@styfle
Copy link
Member

styfle commented Sep 10, 2021

You can try it out today on the canary channel with “yarn add next@canary”

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unhandledRejection: TypeError [ERR_INVALID_ARG_TYPE]
5 participants