Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change create-next-app getting started text in TypeScript template #28718

Merged
merged 3 commits into from
Sep 3, 2021

Conversation

buraksakalli
Copy link
Contributor

@buraksakalli buraksakalli commented Sep 1, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Sep 1, 2021
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Sep 2, 2021

Failing test suites

Commit: afd903b

test/acceptance/ReactRefreshLogBox.dev.test.js

  • component props errors
Expand output

● component props errors

expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true

  845 |   expect(await session.hasRedbox(true)).toBe(true)
  846 |   const source = await session.getRedboxSource()
> 847 |   expect(source).toMatch('./index.module.css:1:1')
      |                                       ^
  848 |   expect(source).toMatch('Syntax error: ')
  849 |   expect(source).toMatch('Unclosed block')
  850 |   expect(source).toMatch('> 1 | .button {')

  at Object.<anonymous> (acceptance/ReactRefreshLogBox.dev.test.js:847:39)

@timneutkens timneutkens changed the title UPDATE: pages/index.js text changed with pages/index.tsx for TS template Change create-next-app getting started text in TypeScript template Sep 2, 2021
@ijjk
Copy link
Member

ijjk commented Sep 3, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
buildDuration 15.6s 16.2s ⚠️ +599ms
buildDurationCached 4.1s 3.9s -134ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall increase ✓
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
/ failed reqs 0 0
/ total time (seconds) 3.153 3.142 -0.01
/ avg req/sec 792.98 795.71 +2.73
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.927 1.884 -0.04
/error-in-render avg req/sec 1297.4 1327.03 +29.63
Client Bundles (main, webpack, commons)
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
_buildManifest.js gzip 492 B 492 B
Overall change 492 B 492 B
Rendered Page Sizes
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
index.html gzip 541 B 541 B
link.html gzip 553 B 553 B
withRouter.html gzip 533 B 533 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
buildDuration 12.7s 12.7s ⚠️ +43ms
buildDurationCached 5.3s 5.2s -83ms
nodeModulesSize 49.1 MB 49.1 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
/ failed reqs 0 0
/ total time (seconds) 3.141 3.136 0
/ avg req/sec 795.99 797.2 +1.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.926 1.96 ⚠️ +0.03
/error-in-render avg req/sec 1298.03 1275.61 ⚠️ -22.42
Client Bundles (main, webpack, commons)
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.7 kB 10.7 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68.1 kB 68.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary buraksakalli/next.js fix/tsx-text Change
index.html gzip 584 B 584 B
link.html gzip 596 B 596 B
withRouter.html gzip 577 B 577 B
Overall change 1.76 kB 1.76 kB
Commit: 9495bd6

@kodiakhq kodiakhq bot merged commit 1b8bc24 into vercel:canary Sep 3, 2021
bordeo pushed a commit to filoblu/next.js that referenced this pull request Sep 6, 2021
* 'canary' of github.com:filoblu/next.js:
  Reuse warning from postcss-loader (vercel#28727)
  Add RenderResult class (vercel#28776)
  v11.1.3-canary.8
  feat: Adding generic typing for previewData (vercel#28668)
  Change create-next-app getting started text in TypeScript template (vercel#28718)
  [ESLint Plugin] Updates `no-document-import-in-page` rule to use `path` separators (vercel#28768)
  Update to new npm publish token (vercel#28772)
  Ensure build trace handles mixed modules (vercel#28770)
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants