Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade webpack and enable experiments.cacheUnaffected #29369

Merged
merged 2 commits into from Sep 24, 2021
Merged

upgrade webpack and enable experiments.cacheUnaffected #29369

merged 2 commits into from Sep 24, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Sep 24, 2021

No description provided.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Sep 24, 2021
@ijjk
Copy link
Member

ijjk commented Sep 24, 2021

Failing test suites

Commit: e6b9459

test/integration/app-document-remove-hmr/test/index.test.js

  • _app removal HMR > should HMR when _document is removed
Expand output

● _app removal HMR › should HMR when _document is removed

TIMED OUT: success

<head><meta charset="utf-8"><meta name="viewport" content="width=device-width"><meta name="next-head-count" content="2"><noscript data-n-css=""></noscript><script defer="" nomodule="" src="/_next/static/chunks/polyfills.js?ts=1632512954456"></script><script src="/_next/static/chunks/webpack.js?ts=1632512954456" defer=""></script><script src="/_next/static/chunks/main.js?ts=1632512954456" defer=""></script><script src="/_next/static/chunks/pages/_app.js?ts=1632512954456" defer=""></script><script src="/_next/static/chunks/pages/index.js?ts=1632512954456" defer=""></script><script src="/_next/static/development/_buildManifest.js?ts=1632512954456" defer=""></script><script src="/_next/static/development/_ssgManifest.js?ts=1632512954456" defer=""></script><noscript id="__next_css__DO_NOT_USE__"></noscript></head><body><div id="__next"><p>custom _app</p><p>index page updated</p></div><script src="/_next/static/chunks/react-refresh.js?ts=1632512954456"></script><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/","query":{},"buildId":"development","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script><div id="__next-build-watcher" style="position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;"></div><next-route-announcer><p aria-live="assertive" id="__next-route-announcer__" role="alert" style="border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px; white-space: nowrap; overflow-wrap: normal;"></p></next-route-announcer></body>

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (integration/app-document-remove-hmr/test/index.test.js:123:7)

@ijjk

This comment has been minimized.

Sign in to view
@sokra sokra marked this pull request as ready for review September 24, 2021 19:57
@ijjk
Copy link
Member

ijjk commented Sep 24, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
buildDuration 15.5s 16.1s ⚠️ +535ms
buildDurationCached 4s 3.8s -199ms
nodeModulesSize 182 MB 182 MB ⚠️ +25.7 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.578 3.464 -0.11
/ avg req/sec 698.75 721.66 +22.91
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.144 1.963 -0.18
/error-in-render avg req/sec 1166.15 1273.69 +107.54
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
779.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27 kB 27 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.8 kB 70.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
_app-HASH.js gzip 977 B 977 B ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 311 B 311 B ✓
css-HASH.js gzip 328 B 328 B ✓
dynamic-HASH.js gzip 2.67 kB 2.67 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 918 B 918 B ✓
image-HASH.js gzip 4.14 kB 4.14 kB ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 13 kB 13 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
_buildManifest.js gzip 493 B 493 B ✓
Overall change 493 B 493 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
index.html gzip 538 B 538 B ✓
link.html gzip 550 B 550 B ✓
withRouter.html gzip 532 B 532 B ✓
Overall change 1.62 kB 1.62 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
buildDuration 7.8s 8.1s ⚠️ +275ms
buildDurationCached 4s 3.9s -91ms
nodeModulesSize 182 MB 182 MB ⚠️ +25.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.418 3.486 ⚠️ +0.07
/ avg req/sec 731.52 717.25 ⚠️ -14.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.99 2.063 ⚠️ +0.07
/error-in-render avg req/sec 1256.32 1211.57 ⚠️ -44.75
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
675-HASH.js gzip 13.8 kB 13.8 kB ✓
770.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 50.7 kB 50.7 kB ✓
main-HASH.js gzip 34.9 kB 34.9 kB ✓
webpack-HASH.js gzip 1.65 kB 1.65 kB ✓
Overall change 101 kB 101 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
_app-HASH.js gzip 1.32 kB 1.32 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 315 B 315 B ✓
css-HASH.js gzip 331 B 331 B ✓
dynamic-HASH.js gzip 2.8 kB 2.8 kB ✓
head-HASH.js gzip 356 B 356 B ✓
hooks-HASH.js gzip 637 B 637 B ✓
image-HASH.js gzip 573 B 573 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 2.2 kB 2.2 kB ✓
routerDirect..HASH.js gzip 326 B 326 B ✓
script-HASH.js gzip 393 B 393 B ✓
withRouter-HASH.js gzip 322 B 322 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 10.1 kB 10.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
_buildManifest.js gzip 511 B 511 B ✓
Overall change 511 B 511 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js perf/webpack-cache-unaffected Change
index.html gzip 539 B 539 B ✓
link.html gzip 551 B 551 B ✓
withRouter.html gzip 532 B 532 B ✓
Overall change 1.62 kB 1.62 kB ✓
Commit: 3ae1be2

@kodiakhq kodiakhq bot merged commit 0976ce2 into canary Sep 24, 2021
@kodiakhq kodiakhq bot deleted the perf/webpack-cache-unaffected branch September 24, 2021 20:45
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@styfle styfle Awaiting requested review from styfle

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sokra @ijjk