Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure blurDataURL is correct in dev with basePath #29436

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 27, 2021

Follow-up to #29307 this ensures the blurDataURL is correctly prefixed with the basePath in development since we use the _next/image endpoint to generate the placeholder in dev mode.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #29289 (comment)

@ijjk
Copy link
Member Author

ijjk commented Sep 27, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
buildDuration 17.1s 17.2s ⚠️ +72ms
buildDurationCached 4.3s 4.3s -35ms
nodeModulesSize 182 MB 182 MB ⚠️ +151 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
/ failed reqs 0 0
/ total time (seconds) 3.818 3.803 -0.02
/ avg req/sec 654.77 657.36 +2.59
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.198 2.136 -0.06
/error-in-render avg req/sec 1137.54 1170.47 +32.93
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27 kB 27 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.8 kB 70.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.15 kB 4.15 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
index.html gzip 539 B 539 B
link.html gzip 550 B 550 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
buildDuration 8.7s 8.8s ⚠️ +75ms
buildDurationCached 4.2s 4.5s ⚠️ +278ms
nodeModulesSize 182 MB 182 MB ⚠️ +151 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
/ failed reqs 0 0
/ total time (seconds) 3.851 3.75 -0.1
/ avg req/sec 649.11 666.7 +17.59
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.094 2.061 -0.03
/error-in-render avg req/sec 1193.67 1213.18 +19.51
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.9 kB 34.9 kB
webpack-HASH.js gzip 1.65 kB 1.65 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
_app-HASH.js gzip 1.32 kB 1.32 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.8 kB 2.8 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/dev-blur-url Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB
Commit: a4c8d66

@ijjk ijjk marked this pull request as ready for review September 27, 2021 18:28
@kodiakhq kodiakhq bot merged commit 7bbaff7 into vercel:canary Sep 27, 2021
@ijjk ijjk deleted the fix/dev-blur-url branch September 27, 2021 21:13
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing image doesn't work with basePath
2 participants