Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use xxhash64 by default #30095

Merged
merged 4 commits into from Oct 20, 2021
Merged

use xxhash64 by default #30095

merged 4 commits into from Oct 20, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 20, 2021 •
edited by ijjk

Node.js 17 stopped supporting md4 as hash function

and we wanted to use a faster hash function anyway.

Fixes: #30078

@sokra
use xxhash64 by default
8ccec9a 
Node.js 17 stopped supporting md4 as hash function
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 20, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@matamatanot matamatanot mentioned this pull request Oct 20, 2021
Closed
@sokra sokra marked this pull request as ready for review October 20, 2021 17:25
ijjk
ijjk previously approved these changes Oct 20, 2021
View reviewed changes
styfle
styfle previously approved these changes Oct 20, 2021
View reviewed changes
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Oct 20, 2021

Failing test suites

Commit: 956cab4

test/development/basic-basepath/hmr.test.ts

  • basic HMR > Error Recovery > should recover from errors in the render function
  • basic HMR > Error Recovery > should recover after a bad return from the render function
  • basic HMR > Error Recovery > should recover after undefined exported as default
Expand output

● basic HMR › Error Recovery › should recover from errors in the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic-basepath/hmr.test.ts:458:9)

● basic HMR › Error Recovery › should recover after a bad return from the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic-basepath/hmr.test.ts:561:9)

● basic HMR › Error Recovery › should recover after undefined exported as default

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic-basepath/hmr.test.ts:617:8)

@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk dismissed stale reviews from styfle and themself via 3f4891e October 20, 2021 20:58
@ijjk
Copy link
Member

ijjk commented Oct 20, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/hash-function Change
buildDuration 17.9s 17.4s -487ms
buildDurationCached 4s 3.9s -76ms
nodeModulesSize 195 MB 195 MB ⚠️ +150 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js bugfix/hash-function Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.184 4.209 ⚠️ +0.02
/ avg req/sec 597.5 594.02 ⚠️ -3.48
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.226 2.21 -0.02
/error-in-render avg req/sec 1123.01 1131.32 +8.31
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/hash-function Change
651.HASH.js gzip 2.96 kB 2.96 kB ✓
831.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 26.1 kB 26.1 kB ✓
webpack-HASH.js gzip 1.49 kB 1.47 kB -11 B
Overall change 73 kB 73 kB -11 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/hash-function Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/hash-function Change
_app-HASH.js gzip 979 B 979 B ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 551 B 551 B ✓
css-HASH.js gzip 329 B 329 B ✓
dynamic-HASH.js gzip 2.67 kB 2.67 kB ✓
head-HASH.js gzip 2.32 kB 2.32 kB ✓
hooks-HASH.js gzip 918 B 917 B -1 B
image-HASH.js gzip 5.87 kB 5.87 kB ⚠️ +2 B
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 319 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 19.8 kB 19.8 kB ⚠️ +1 B
Client Build Manifests Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/hash-function Change
_buildManifest.js gzip 492 B 458 B -34 B
Overall change 492 B 458 B -34 B
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/hash-function Change
index.html gzip 548 B 537 B -11 B
link.html gzip 560 B 548 B -12 B
withRouter.html gzip 542 B 529 B -13 B
Overall change 1.65 kB 1.61 kB -36 B

Diffs

Diff for _buildManifest.js 
@@ -1,33 +1,25 @@
 self.__BUILD_MANIFEST = {
   __rewrites: { beforeFiles: [], afterFiles: [], fallback: [] },
-  "/": ["static\u002Fchunks\u002Fpages\u002Findex-cb1865344b5f4c2fb9b1.js"],
-  "/_error": [
-    "static\u002Fchunks\u002Fpages\u002F_error-29b2ff6b77b82b6aae19.js"
-  ],
-  "/amp": ["static\u002Fchunks\u002Fpages\u002Famp-dcba8dbcc08f722a3744.js"],
+  "/": ["static\u002Fchunks\u002Fpages\u002Findex-843adaf946d87644.js"],
+  "/_error": ["static\u002Fchunks\u002Fpages\u002F_error-c781952f352e4219.js"],
+  "/amp": ["static\u002Fchunks\u002Fpages\u002Famp-b11421da95e6cd65.js"],
   "/css": [
-    "static\u002Fcss\u002F59de118426c393f58653.css",
-    "static\u002Fchunks\u002Fpages\u002Fcss-abb90d4fd0438c9acb21.js"
+    "static\u002Fcss\u002Fb05d9375ec06fe1b.css",
+    "static\u002Fchunks\u002Fpages\u002Fcss-3082f38ec4aa6063.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-8ca90971eb23b66158ae.js"
-  ],
-  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-a56ce906cb9862bdd7a6.js"],
-  "/hooks": [
-    "static\u002Fchunks\u002Fpages\u002Fhooks-bf79a138d8e688b555b9.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-e9949e65f81038fb.js"
   ],
-  "/image": [
-    "static\u002Fchunks\u002Fpages\u002Fimage-1665fedda9c131a57d49.js"
-  ],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-8b0763ffcf5bfe998a56.js"],
+  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-a9a93d991a2a6a9c.js"],
+  "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-e040764724fe6a41.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-a4027db8f96167d6.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-f632234727179322.js"],
   "/routerDirect": [
-    "static\u002Fchunks\u002Fpages\u002FrouterDirect-6b6565ccfa1d16752c35.js"
-  ],
-  "/script": [
-    "static\u002Fchunks\u002Fpages\u002Fscript-9028194f7770951161c7.js"
+    "static\u002Fchunks\u002Fpages\u002FrouterDirect-df7921033b292f8a.js"
   ],
+  "/script": ["static\u002Fchunks\u002Fpages\u002Fscript-c65470edc1e9d9b6.js"],
   "/withRouter": [
-    "static\u002Fchunks\u002Fpages\u002FwithRouter-f945eb2325ed595c0b8c.js"
+    "static\u002Fchunks\u002Fpages\u002FwithRouter-070ef9975918e033.js"
   ],
   sortedPages: [
     "\u002F",
Diff for hooks-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [757],
   {
-    /***/ 5438: /***/ function(
+    /***/ 2709: /***/ function(
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -144,7 +144,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/hooks",
         function() {
-          return __webpack_require__(5438);
+          return __webpack_require__(2709);
         }
       ]);
       if (false) {
Diff for image-HASH.js 
@@ -1554,7 +1554,7 @@
       /***/
     },
 
-    /***/ 966: /***/ function(
+    /***/ 5573: /***/ function(
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -1614,7 +1614,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/image",
         function() {
-          return __webpack_require__(966);
+          return __webpack_require__(5573);
         }
       ]);
       if (false) {
Diff for webpack-HASH.js 
@@ -162,9 +162,7 @@
         "static/chunks/" +
         chunkId +
         "." +
-        { "651": "bd1ea535877a6d46b060", "831": "d937b6deb3044134ec12" }[
-          chunkId
-        ] +
+        { "651": "efb4119f0940cbc6", "831": "2ce3fdfd69aca022" }[chunkId] +
         ".js"
       );
       /******/
@@ -177,7 +175,7 @@
     /******/ // This function allow to reference all chunks
     /******/ __webpack_require__.miniCssF = function(chunkId) {
       /******/ // return url for filenames based on template
-      /******/ return "static/css/" + "59de118426c393f58653" + ".css";
+      /******/ return "static/css/" + "b05d9375ec06fe1b" + ".css";
       /******/
     };
     /******/
Diff for index.html 
@@ -11,23 +11,23 @@
       src="/_next/static/chunks/polyfills-a40ef1678bae11e696dba45124eadd70.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-25db849a2adecb94d674.js"
+      src="/_next/static/chunks/webpack-d777d1afc4046152.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/framework-04992f11eed687ecc749.js"
+      src="/_next/static/chunks/framework-535325b9235a831f.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b5f8aa016bc1413f3beb.js"
+      src="/_next/static/chunks/main-a3ba4ef80a1d806e.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-a69345869b722bc18486.js"
+      src="/_next/static/chunks/pages/_app-3ab6a24eae9d4d66.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/index-cb1865344b5f4c2fb9b1.js"
+      src="/_next/static/chunks/pages/index-843adaf946d87644.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Diff for link.html 
@@ -11,23 +11,23 @@
       src="/_next/static/chunks/polyfills-a40ef1678bae11e696dba45124eadd70.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-25db849a2adecb94d674.js"
+      src="/_next/static/chunks/webpack-d777d1afc4046152.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/framework-04992f11eed687ecc749.js"
+      src="/_next/static/chunks/framework-535325b9235a831f.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b5f8aa016bc1413f3beb.js"
+      src="/_next/static/chunks/main-a3ba4ef80a1d806e.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-a69345869b722bc18486.js"
+      src="/_next/static/chunks/pages/_app-3ab6a24eae9d4d66.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-8b0763ffcf5bfe998a56.js"
+      src="/_next/static/chunks/pages/link-f632234727179322.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Diff for withRouter.html 
@@ -11,23 +11,23 @@
       src="/_next/static/chunks/polyfills-a40ef1678bae11e696dba45124eadd70.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-25db849a2adecb94d674.js"
+      src="/_next/static/chunks/webpack-d777d1afc4046152.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/framework-04992f11eed687ecc749.js"
+      src="/_next/static/chunks/framework-535325b9235a831f.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b5f8aa016bc1413f3beb.js"
+      src="/_next/static/chunks/main-a3ba4ef80a1d806e.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-a69345869b722bc18486.js"
+      src="/_next/static/chunks/pages/_app-3ab6a24eae9d4d66.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/withRouter-f945eb2325ed595c0b8c.js"
+      src="/_next/static/chunks/pages/withRouter-070ef9975918e033.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/hash-function Change
buildDuration 8.4s 8.3s -90ms
buildDurationCached 3.9s 3.9s -56ms
nodeModulesSize 195 MB 195 MB ⚠️ +150 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/hash-function Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.22 4.572 ⚠️ +0.35
/ avg req/sec 592.48 546.75 ⚠️ -45.73
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.25 2.173 -0.08
/error-in-render avg req/sec 1111.1 1150.55 +39.45
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/hash-function Change
450.HASH.js gzip 179 B 179 B ✓
675-HASH.js gzip 13.9 kB 13.9 kB ✓
framework-HASH.js gzip 50.8 kB 50.8 kB ✓
main-HASH.js gzip 36.5 kB 36.5 kB ✓
webpack-HASH.js gzip 1.64 kB 1.63 kB -7 B
Overall change 103 kB 103 kB -7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/hash-function Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/hash-function Change
_app-HASH.js gzip 1.33 kB 1.33 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 315 B 315 B ✓
css-HASH.js gzip 330 B 330 B ✓
dynamic-HASH.js gzip 2.79 kB 2.79 kB ✓
head-HASH.js gzip 356 B 356 B ✓
hooks-HASH.js gzip 638 B 638 B ✓
image-HASH.js gzip 556 B 555 B -1 B
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 2.22 kB 2.22 kB ✓
routerDirect..HASH.js gzip 325 B 325 B ✓
script-HASH.js gzip 390 B 390 B ✓
withRouter-HASH.js gzip 322 B 322 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 10.1 kB 10.1 kB -1 B
Client Build Manifests Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/hash-function Change
_buildManifest.js gzip 512 B 476 B -36 B
Overall change 512 B 476 B -36 B
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/hash-function Change
index.html gzip 547 B 535 B -12 B
link.html gzip 560 B 546 B -14 B
withRouter.html gzip 541 B 529 B -12 B
Overall change 1.65 kB 1.61 kB -38 B

Diffs

Diff for _buildManifest.js 
@@ -1,34 +1,28 @@
 self.__BUILD_MANIFEST = {
   __rewrites: { beforeFiles: [], afterFiles: [], fallback: [] },
-  "/": ["static\u002Fchunks\u002Fpages\u002Findex-f298f8e31fd726230f06.js"],
-  "/_error": [
-    "static\u002Fchunks\u002Fpages\u002F_error-52a148be71f94b5fc7ac.js"
-  ],
-  "/amp": ["static\u002Fchunks\u002Fpages\u002Famp-f50aa6693827f0008445.js"],
+  "/": ["static\u002Fchunks\u002Fpages\u002Findex-22405fb865808942.js"],
+  "/_error": ["static\u002Fchunks\u002Fpages\u002F_error-97db2c91e74bb63f.js"],
+  "/amp": ["static\u002Fchunks\u002Fpages\u002Famp-8c7b17a56b7abb6e.js"],
   "/css": [
-    "static\u002Fcss\u002F59de118426c393f58653.css",
-    "static\u002Fchunks\u002Fpages\u002Fcss-ec9c76a3bbaaafc13a5c.js"
+    "static\u002Fcss\u002Fb05d9375ec06fe1b.css",
+    "static\u002Fchunks\u002Fpages\u002Fcss-99ad492aad2c14e4.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-07ad5ad32526019975b2.js"
-  ],
-  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-76908dd010302562b01c.js"],
-  "/hooks": [
-    "static\u002Fchunks\u002Fpages\u002Fhooks-2eb3c32be6fd6a803111.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-b29c333f50a1421d.js"
   ],
+  "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-7100d3b2a548f0e4.js"],
+  "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-ff60bc61acd2698b.js"],
   "/image": [
-    "static\u002Fchunks\u002F675-84ca8ec4bee4ac87888c.js",
-    "static\u002Fchunks\u002Fpages\u002Fimage-9b92b7d0657520ea92a8.js"
+    "static\u002Fchunks\u002F675-95a9b16c17266546.js",
+    "static\u002Fchunks\u002Fpages\u002Fimage-16126fc55fe0de81.js"
   ],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-0e1415574bc8bcee0f63.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-b43e080ed9faa750.js"],
   "/routerDirect": [
-    "static\u002Fchunks\u002Fpages\u002FrouterDirect-f56a6bf91a633bc21711.js"
-  ],
-  "/script": [
-    "static\u002Fchunks\u002Fpages\u002Fscript-5f7436913f89434e27c5.js"
+    "static\u002Fchunks\u002Fpages\u002FrouterDirect-76232dd6bc335a24.js"
   ],
+  "/script": ["static\u002Fchunks\u002Fpages\u002Fscript-52713a82413f16bb.js"],
   "/withRouter": [
-    "static\u002Fchunks\u002Fpages\u002FwithRouter-4262b10ef3ead2ed1cf7.js"
+    "static\u002Fchunks\u002Fpages\u002FwithRouter-50f69b5840cc7abf.js"
   ],
   sortedPages: [
     "\u002F",
Diff for image-HASH.js 
@@ -9,7 +9,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/image",
         function() {
-          return __webpack_require__(1269);
+          return __webpack_require__(3155);
         }
       ]);
       if (false) {
@@ -18,7 +18,7 @@
       /***/
     },
 
-    /***/ 1269: /***/ function(
+    /***/ 3155: /***/ function(
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
Diff for webpack-HASH.js 
@@ -159,7 +159,7 @@
     /******/ __webpack_require__.u = function(chunkId) {
       /******/ // return url for filenames based on template
       /******/ return (
-        "static/chunks/" + chunkId + "." + "4237ce114c811ef25549" + ".js"
+        "static/chunks/" + chunkId + "." + "2f05e31c20cc50e8" + ".js"
       );
       /******/
     };
@@ -171,7 +171,7 @@
     /******/ // This function allow to reference all chunks
     /******/ __webpack_require__.miniCssF = function(chunkId) {
       /******/ // return url for filenames based on template
-      /******/ return "static/css/" + "59de118426c393f58653" + ".css";
+      /******/ return "static/css/" + "b05d9375ec06fe1b" + ".css";
       /******/
     };
     /******/
Diff for index.html 
@@ -11,23 +11,23 @@
       src="/_next/static/chunks/polyfills-a40ef1678bae11e696dba45124eadd70.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-f9a4de8b7e4ae5f65fe8.js"
+      src="/_next/static/chunks/webpack-57a4fdebaa1fd046.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/framework-04992f11eed687ecc749.js"
+      src="/_next/static/chunks/framework-535325b9235a831f.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-eed26607c60424f3c771.js"
+      src="/_next/static/chunks/main-723b8035d083375c.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-0d67a5269bd703adc4bc.js"
+      src="/_next/static/chunks/pages/_app-4255d5124b5f151e.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/index-f298f8e31fd726230f06.js"
+      src="/_next/static/chunks/pages/index-22405fb865808942.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Diff for link.html 
@@ -11,23 +11,23 @@
       src="/_next/static/chunks/polyfills-a40ef1678bae11e696dba45124eadd70.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-f9a4de8b7e4ae5f65fe8.js"
+      src="/_next/static/chunks/webpack-57a4fdebaa1fd046.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/framework-04992f11eed687ecc749.js"
+      src="/_next/static/chunks/framework-535325b9235a831f.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-eed26607c60424f3c771.js"
+      src="/_next/static/chunks/main-723b8035d083375c.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-0d67a5269bd703adc4bc.js"
+      src="/_next/static/chunks/pages/_app-4255d5124b5f151e.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-0e1415574bc8bcee0f63.js"
+      src="/_next/static/chunks/pages/link-b43e080ed9faa750.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Diff for withRouter.html 
@@ -11,23 +11,23 @@
       src="/_next/static/chunks/polyfills-a40ef1678bae11e696dba45124eadd70.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-f9a4de8b7e4ae5f65fe8.js"
+      src="/_next/static/chunks/webpack-57a4fdebaa1fd046.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/framework-04992f11eed687ecc749.js"
+      src="/_next/static/chunks/framework-535325b9235a831f.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-eed26607c60424f3c771.js"
+      src="/_next/static/chunks/main-723b8035d083375c.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/_app-0d67a5269bd703adc4bc.js"
+      src="/_next/static/chunks/pages/_app-4255d5124b5f151e.js"
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/withRouter-4262b10ef3ead2ed1cf7.js"
+      src="/_next/static/chunks/pages/withRouter-50f69b5840cc7abf.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Commit: 3f4891e

@kodiakhq kodiakhq bot merged commit 610d2b3 into canary Oct 20, 2021
@kodiakhq kodiakhq bot deleted the bugfix/hash-function branch October 20, 2021 21:39
@ijjk ijjk mentioned this pull request Oct 24, 2021
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@styfle styfle styfle left review comments

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node.js v17.0.0 - Error starting project in development mode
3 participants
@sokra @ijjk @styfle