fix rsc on windows #30364
Merged
fix rsc on windows #30364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
requested review from
huozhi,
ijjk,
padmaia,
shuding,
styfle and
timneutkens
as code owners
ijjk
previously approved these changes
Oct 26, 2021
styfle
previously approved these changes
Oct 26, 2021
styfle
reviewed
Oct 26, 2021
Comment on lines
106
to
108
| let modId: string | ||
|
|
||
| const context = compiler.context | ||
| const nameForCondition = mod.nameForCondition() | ||
|
|
||
| if (nameForCondition && nameForCondition.startsWith(context)) { | ||
| modId = '.' + nameForCondition.slice(context.length) | ||
| } else { | ||
| modId = compilation.chunkGraph.getModuleId(mod) | ||
| } | ||
| modId = compilation.chunkGraph.getModuleId(mod) |
There was a problem hiding this comment.
You can do let modId = and remove line 106 😎
sokra
force-pushed
the
bugfix/rsc-windows
branch
from
f94ad44
to
0ddd0ee
Compare
huozhi
approved these changes
Oct 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.