Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playwright trace names #30374

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 26, 2021

This ensures we use the URL for the active trace when writing the data instead of new URL that's about to start tracing.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Oct 26, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Oct 27, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
buildDuration 23.3s 23.4s ⚠️ +86ms
buildDurationCached 4.8s 4.6s -121ms
nodeModulesSize 207 MB 207 MB ⚠️ +4 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
/ failed reqs 0 0
/ total time (seconds) 4.044 4.074 ⚠️ +0.03
/ avg req/sec 618.2 613.67 ⚠️ -4.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.218 2.147 -0.07
/error-in-render avg req/sec 1127.15 1164.54 +37.39
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
index.html gzip 535 B 535 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
buildDuration 20.3s 18.4s -1.9s
buildDurationCached 4.7s 4.2s -458ms
nodeModulesSize 207 MB 207 MB ⚠️ +4 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
/ failed reqs 0 0
/ total time (seconds) 4.08 3.754 -0.33
/ avg req/sec 612.72 665.9 +53.18
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.129 1.994 -0.13
/error-in-render avg req/sec 1174.11 1253.8 +79.69
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 621 B 621 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/playwright-trace-names Change
index.html gzip 535 B 535 B
link.html gzip 547 B 547 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB
Commit: 33a0d10

@ijjk ijjk merged commit 7a34e5e into vercel:canary Oct 27, 2021
@ijjk ijjk deleted the fix/playwright-trace-names branch October 27, 2021 05:10
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants