Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exportRuntime and react-18 concurrent tests #30381

Merged
merged 2 commits into from Oct 26, 2021
Merged

Fix exportRuntime and react-18 concurrent tests #30381

merged 2 commits into from Oct 26, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Oct 26, 2021

  • disable concurrent test cases in short term to improve them later
  • remove bad alias in next.config.js

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 26, 2021
@huozhi huozhi changed the title tests: fix react-18 concurrent tests Fix exportRuntime and react-18 concurrent tests Oct 26, 2021
@huozhi huozhi requested a review from styfle October 26, 2021 22:50
@ijjk
Copy link
Member

ijjk commented Oct 26, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
buildDuration 16.5s 16.1s -405ms
buildDurationCached 3.4s 3.5s ⚠️ +86ms
nodeModulesSize 207 MB 207 MB ⚠️ +7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.601 2.678 ⚠️ +0.08
/ avg req/sec 961.05 933.44 ⚠️ -27.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.268 1.275 ⚠️ +0.01
/error-in-render avg req/sec 1971 1960.31 ⚠️ -10.69
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28 kB 28 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 71.9 kB 71.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
_app-HASH.js gzip 1.23 kB 1.23 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.44 kB 4.44 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
index.html gzip 534 B 534 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
buildDuration 14.8s 14.3s -481ms
buildDurationCached 3.8s 3.3s -532ms
nodeModulesSize 207 MB 207 MB ⚠️ +7 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.781 2.845 ⚠️ +0.06
/ avg req/sec 898.99 878.87 ⚠️ -20.12
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.345 1.298 -0.05
/error-in-render avg req/sec 1859.06 1926.41 +67.35
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28.2 kB 28.2 kB ✓
webpack-HASH.js gzip 1.43 kB 1.43 kB ✓
Overall change 72 kB 72 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
_app-HASH.js gzip 1.22 kB 1.22 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 621 B 621 B ✓
image-HASH.js gzip 4.46 kB 4.46 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.9 kB 1.9 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/react-18-tests Change
index.html gzip 534 B 534 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 0ddfba2

@kodiakhq kodiakhq bot merged commit 8e40554 into vercel:canary Oct 26, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@huozhi huozhi deleted the fix/react-18-tests branch February 3, 2022 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding left review comments

@styfle styfle styfle approved these changes

@ijjk ijjk ijjk approved these changes

@padmaia padmaia Awaiting requested review from padmaia

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@huozhi @ijjk @styfle @shuding