fix external fallback for invalid packages #30427

sokra · 2021-10-27T11:36:22Z

fallback to alternative external version also when it fails because of base resolve mismatch#

fix resolved .mjs modules treated as external

fixes #30330

ijjk · 2021-10-27T11:59:09Z

Failing test suites

Commit: a6f7899

test/integration/externals-esm/test/index.test.js

Handle ESM externals with esmExternals: true > should render the static page
Handle ESM externals with esmExternals: true > should render the ssr page
Handle ESM externals with esmExternals: true > should render the ssg page

Expand output

● Handle ESM externals with esmExternals: true › should render the static page

expect(received).toMatch(expected)

Expected pattern: /Hello <!-- -->World<!-- -->\+<!-- -->World\+<!-- -->World<!-- -->\+<!-- -->World\+World\+World/
Received string:  "<!DOCTYPE html><html><head><meta charSet=\"utf-8\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta name=\"next-head-count\" content=\"2\"/><noscript data-n-css=\"\"></noscript><script defer=\"\" nomodule=\"\" src=\"/_next/static/chunks/polyfills-a40ef1678bae11e696dba45124eadd70.js\"></script><script src=\"/_next/static/chunks/webpack-45f9f9587e6c08e1.js\" defer=\"\"></script><script src=\"/_next/static/chunks/framework-79033b63c4c1e843.js\" defer=\"\"></script><script src=\"/_next/static/chunks/main-bb50817144bddff7.js\" defer=\"\"></script><script src=\"/_next/static/chunks/pages/_app-f8009117fbc912ad.js\" defer=\"\"></script><script src=\"/_next/static/chunks/pages/static-df6dfe11a3c25146.js\" defer=\"\"></script><script src=\"/_next/static/l1R2wFte6TyOV9CFS83Hm/_buildManifest.js\" defer=\"\"></script><script src=\"/_next/static/l1R2wFte6TyOV9CFS83Hm/_ssgManifest.js\" defer=\"\"></script><script src=\"/_next/static/l1R2wFte6TyOV9CFS83Hm/_middlewareManifest.js\" defer=\"\"></script></head><body><div id=\"__next\"><div>Hello <!-- -->World<!-- -->+<!-- -->World<!-- -->+<!-- -->World<!-- -->+<!-- -->World+World+World</div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/static\",\"query\":{},\"buildId\":\"l1R2wFte6TyOV9CFS83Hm\",\"nextExport\":true,\"autoExport\":true,\"isFallback\":false,\"scriptLoader\":[]}</script></body></html>"

  29 |   it('should render the static page', async () => {
  30 |     const html = await renderViaHTTP(appPort, '/static')
> 31 |     expect(html).toMatch(expected)
     |                  ^
  32 |   })
  33 |
  34 |   it('should render the ssr page', async () => {

  at Object.<anonymous> (integration/externals-esm/test/index.test.js:31:18)

● Handle ESM externals with esmExternals: true › should render the ssr page

expect(received).toMatch(expected)

Expected pattern: /Hello <!-- -->World<!-- -->\+<!-- -->World\+<!-- -->World<!-- -->\+<!-- -->World\+World\+World/
Received string:  "<!DOCTYPE html><html><head><meta charSet=\"utf-8\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta name=\"next-head-count\" content=\"2\"/><noscript data-n-css=\"\"></noscript><script defer=\"\" nomodule=\"\" src=\"/_next/static/chunks/polyfills-a40ef1678bae11e696dba45124eadd70.js\"></script><script src=\"/_next/static/chunks/webpack-45f9f9587e6c08e1.js\" defer=\"\"></script><script src=\"/_next/static/chunks/framework-79033b63c4c1e843.js\" defer=\"\"></script><script src=\"/_next/static/chunks/main-bb50817144bddff7.js\" defer=\"\"></script><script src=\"/_next/static/chunks/pages/_app-f8009117fbc912ad.js\" defer=\"\"></script><script src=\"/_next/static/chunks/pages/ssr-e4683888cfedd209.js\" defer=\"\"></script><script src=\"/_next/static/l1R2wFte6TyOV9CFS83Hm/_buildManifest.js\" defer=\"\"></script><script src=\"/_next/static/l1R2wFte6TyOV9CFS83Hm/_ssgManifest.js\" defer=\"\"></script><script src=\"/_next/static/l1R2wFte6TyOV9CFS83Hm/_middlewareManifest.js\" defer=\"\"></script></head><body><div id=\"__next\"><div>Hello <!-- -->World<!-- -->+<!-- -->World<!-- -->+<!-- -->World<!-- -->+<!-- -->World+World+World</div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"worlds\":\"World+World+World\"},\"__N_SSP\":true},\"page\":\"/ssr\",\"query\":{},\"buildId\":\"l1R2wFte6TyOV9CFS83Hm\",\"isFallback\":false,\"gssp\":true,\"scriptLoader\":[]}</script></body></html>"

  34 |   it('should render the ssr page', async () => {
  35 |     const html = await renderViaHTTP(appPort, '/ssr')
> 36 |     expect(html).toMatch(expected)
     |                  ^
  37 |   })
  38 |
  39 |   it('should render the ssg page', async () => {

  at Object.<anonymous> (integration/externals-esm/test/index.test.js:36:18)

● Handle ESM externals with esmExternals: true › should render the ssg page

expect(received).toMatch(expected)

Expected pattern: /Hello <!-- -->World<!-- -->\+<!-- -->World\+<!-- -->World<!-- -->\+<!-- -->World\+World\+World/
Received string:  "<!DOCTYPE html><html><head><meta charSet=\"utf-8\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta name=\"next-head-count\" content=\"2\"/><noscript data-n-css=\"\"></noscript><script defer=\"\" nomodule=\"\" src=\"/_next/static/chunks/polyfills-a40ef1678bae11e696dba45124eadd70.js\"></script><script src=\"/_next/static/chunks/webpack-45f9f9587e6c08e1.js\" defer=\"\"></script><script src=\"/_next/static/chunks/framework-79033b63c4c1e843.js\" defer=\"\"></script><script src=\"/_next/static/chunks/main-bb50817144bddff7.js\" defer=\"\"></script><script src=\"/_next/static/chunks/pages/_app-f8009117fbc912ad.js\" defer=\"\"></script><script src=\"/_next/static/chunks/pages/ssg-6e40daafc5d083d5.js\" defer=\"\"></script><script src=\"/_next/static/l1R2wFte6TyOV9CFS83Hm/_buildManifest.js\" defer=\"\"></script><script src=\"/_next/static/l1R2wFte6TyOV9CFS83Hm/_ssgManifest.js\" defer=\"\"></script><script src=\"/_next/static/l1R2wFte6TyOV9CFS83Hm/_middlewareManifest.js\" defer=\"\"></script></head><body><div id=\"__next\"><div>Hello <!-- -->World<!-- -->+<!-- -->World<!-- -->+<!-- -->World<!-- -->+<!-- -->World+World+World</div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"worlds\":\"World+World+World\"},\"__N_SSG\":true},\"page\":\"/ssg\",\"query\":{},\"buildId\":\"l1R2wFte6TyOV9CFS83Hm\",\"isFallback\":false,\"gsp\":true,\"scriptLoader\":[]}</script></body></html>"

  39 |   it('should render the ssg page', async () => {
  40 |     const html = await renderViaHTTP(appPort, '/ssg')
> 41 |     expect(html).toMatch(expected)
     |                  ^
  42 |   })
  43 | })
  44 |

  at Object.<anonymous> (integration/externals-esm/test/index.test.js:41:18)

fallback to alternative external version also when it fails because of base resolve mismatch# fix resolved .mjs modules treated as external

ijjk · 2021-10-27T12:30:39Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
buildDuration	21.6s	21.3s	-297ms
buildDurationCached	4.1s	4.3s	⚠️ +201ms
nodeModulesSize	207 MB	207 MB	⚠️ +751 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.607	3.729	⚠️ +0.12
/ avg req/sec	693.18	670.38	⚠️ -22.8
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.999	1.983	-0.02
/error-in-render avg req/sec	1250.53	1260.99	+10.46

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28 kB	28 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	71.9 kB	71.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
_app-HASH.js gzip	1.23 kB	1.23 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.44 kB	4.44 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
334f979574ae..6f4.css gzip	106 B	106 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
index.html gzip	535 B	535 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.61 kB	1.61 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
buildDuration	18.4s	18.9s	⚠️ +547ms
buildDurationCached	4.4s	4.5s	⚠️ +109ms
nodeModulesSize	207 MB	207 MB	⚠️ +751 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.806	3.828	⚠️ +0.02
/ avg req/sec	656.87	653.12	⚠️ -3.75
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.008	1.934	-0.07
/error-in-render avg req/sec	1244.77	1292.73	+47.96

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.2 kB	28.2 kB	✓
webpack-HASH.js gzip	1.43 kB	1.43 kB	✓
Overall change	72 kB	72 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
_app-HASH.js gzip	1.22 kB	1.22 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	621 B	621 B	✓
image-HASH.js gzip	4.46 kB	4.46 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.9 kB	1.9 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
334f979574ae..6f4.css gzip	106 B	106 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bugfix/externals-chakra-ui	Change
index.html gzip	534 B	534 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: 497cdfd

ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 27, 2021

This comment has been minimized.

Sign in to view

fix external fallback for invalid packages

497cdfd

fallback to alternative external version also when it fails because of base resolve mismatch# fix resolved .mjs modules treated as external

sokra force-pushed the bugfix/externals-chakra-ui branch from a6f7899 to 497cdfd Compare October 27, 2021 12:13

sokra marked this pull request as ready for review October 27, 2021 12:44

sokra requested review from huozhi, ijjk, padmaia, shuding, styfle and timneutkens as code owners October 27, 2021 12:44

timneutkens approved these changes Oct 27, 2021

View reviewed changes

kodiakhq bot merged commit f7048b5 into canary Oct 27, 2021

kodiakhq bot deleted the bugfix/externals-chakra-ui branch October 27, 2021 13:53

ijjk mentioned this pull request Oct 28, 2021

Share resolve logic for trace and externals #30499

Merged

10 tasks

styfle added the hacktoberfest-accepted label Oct 31, 2021

KevinShiCA mentioned this pull request Nov 1, 2021

Next.js 12.0.2 + Framer 5.0.1 leading to errors in production #30750

Closed

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix external fallback for invalid packages #30427

fix external fallback for invalid packages #30427

sokra commented Oct 27, 2021

This comment has been minimized.

ijjk commented Oct 27, 2021

ijjk commented Oct 27, 2021

fix external fallback for invalid packages #30427

fix external fallback for invalid packages #30427

Conversation

sokra commented Oct 27, 2021

This comment has been minimized.

ijjk commented Oct 27, 2021

Failing test suites

ijjk commented Oct 27, 2021

Stats from current PR