Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postinstall script to install native packages #30850

Merged
merged 4 commits into from
Nov 2, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Nov 2, 2021

This change adds a postinstall script that downloads the most recent binary packages instead of adding them as optionalDependencies of the root package. Adding these packages as optionalDependencies causes problems because the yarn.lock needs to be updated during the publish job, but that job happens on a protected branch.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Nov 2, 2021
scripts/install-native.mjs Outdated Show resolved Hide resolved
scripts/install-native.mjs Outdated Show resolved Hide resolved
@padmaia padmaia force-pushed the fix/keep-binaries-up-to-date branch from 6cd382b to 3480071 Compare November 2, 2021 22:46
@ijjk

This comment has been minimized.

Co-authored-by: JJ Kasper <jj@jjsweb.site>
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 🎉

@ijjk
Copy link
Member

ijjk commented Nov 2, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
buildDuration 18.5s 18.7s ⚠️ +179ms
buildDurationCached 4s 3.9s -49ms
nodeModulesSize 293 MB 293 MB ⚠️ +1 B
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
/ failed reqs 0 0
/ total time (seconds) 2.946 2.949 0
/ avg req/sec 848.48 847.85 ⚠️ -0.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.427 1.353 -0.07
/error-in-render avg req/sec 1751.62 1847.74 +96.12
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
index.html gzip 521 B 521 B
link.html gzip 533 B 533 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
buildDuration 19.9s 20.1s ⚠️ +135ms
buildDurationCached 4.1s 4.1s ⚠️ +36ms
nodeModulesSize 293 MB 293 MB ⚠️ +1 B
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
/ failed reqs 0 0
/ total time (seconds) 2.934 2.908 -0.03
/ avg req/sec 852.07 859.81 +7.74
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.367 1.371 0
/error-in-render avg req/sec 1829.4 1823.94 ⚠️ -5.46
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js fix/keep-binaries-up-to-date Change
index.html gzip 521 B 521 B
link.html gzip 534 B 534 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: de3c7f9

@padmaia padmaia merged commit b2b7e78 into vercel:canary Nov 2, 2021
@padmaia padmaia deleted the fix/keep-binaries-up-to-date branch November 2, 2021 23:37
@AviVahl
Copy link

AviVahl commented Nov 4, 2021

I've commented in the commit to master instead of here: b2b7e78

Please consider reverting this change.

@padmaia
Copy link
Member Author

padmaia commented Nov 4, 2021

I've responded on the commit as well, but this is just for local development of next.js. It will not affect users of the next package.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants