Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable linux-musl-x64 build target #30910

Merged
merged 6 commits into from
Nov 3, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 3, 2021

This attempts re-enabling the linux-musl-x64 build target and fails publish-native when any target fails to publish again.

x-ref: napi-rs/napi-rs#816 (comment)

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Nov 3, 2021
styfle
styfle previously approved these changes Nov 3, 2021
@ijjk ijjk added the type: next label Nov 3, 2021
@ijjk
Copy link
Member Author

ijjk commented Nov 3, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
buildDuration 22s 22.2s ⚠️ +201ms
buildDurationCached 4.7s 4.7s -61ms
nodeModulesSize 293 MB 293 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
/ failed reqs 0 0
/ total time (seconds) 3.522 3.601 ⚠️ +0.08
/ avg req/sec 709.77 694.26 ⚠️ -15.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.683 1.685 0
/error-in-render avg req/sec 1485.36 1483.41 ⚠️ -1.95
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
index.html gzip 522 B 522 B
link.html gzip 534 B 534 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
buildDuration 24s 23.6s -380ms
buildDurationCached 4.7s 4.6s -113ms
nodeModulesSize 293 MB 293 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
/ failed reqs 0 0
/ total time (seconds) 3.602 3.54 -0.06
/ avg req/sec 694.08 706.26 +12.18
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.753 1.684 -0.07
/error-in-render avg req/sec 1426.49 1484.28 +57.79
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js re-enable/musl-x64 Change
index.html gzip 521 B 521 B
link.html gzip 535 B 535 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB
Commit: 0d8d38a

@ijjk ijjk merged commit 81a4cd2 into vercel:canary Nov 3, 2021
@ijjk ijjk deleted the re-enable/musl-x64 branch November 3, 2021 20:03
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants