Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make missing Document components an error #31505

Merged
merged 4 commits into from Nov 17, 2021

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Nov 16, 2021

Instead of just warning, missing Document components should be an error, as they're all required by Next.js.

@ijjk ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Nov 16, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@devknoll devknoll marked this pull request as ready for review November 16, 2021 22:52
@ijjk
Copy link
Member

ijjk commented Nov 17, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
buildDuration 22s 23.6s ⚠️ +1.6s
buildDurationCached 4.6s 4.2s -353ms
nodeModulesSize 336 MB 336 MB -176 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
/ failed reqs 0 0
/ total time (seconds) 3.742 3.965 ⚠️ +0.22
/ avg req/sec 668.12 630.49 ⚠️ -37.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.003 2.115 ⚠️ +0.11
/error-in-render avg req/sec 1248.31 1181.84 ⚠️ -66.47
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
index.html gzip 524 B 524 B
link.html gzip 536 B 536 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
buildDuration 23.5s 23.7s ⚠️ +228ms
buildDurationCached 4.2s 4.2s -30ms
nodeModulesSize 336 MB 336 MB -176 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
/ failed reqs 0 0
/ total time (seconds) 3.777 3.952 ⚠️ +0.17
/ avg req/sec 661.98 632.6 ⚠️ -29.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.021 2.113 ⚠️ +0.09
/error-in-render avg req/sec 1236.98 1183.26 ⚠️ -53.72
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-fix-missing-components-error Change
index.html gzip 524 B 524 B
link.html gzip 536 B 536 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB
Commit: 0dd7937

@ijjk ijjk merged commit 0cf7061 into vercel:canary Nov 17, 2021
@huozhi huozhi linked an issue Nov 17, 2021 that may be closed by this pull request
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Next 12] Conditional render inside custom document causes error
3 participants