Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support de-deduping head tags by setting key #3170

Merged
merged 6 commits into from Oct 31, 2017
Merged

Support de-deduping head tags by setting key #3170

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b77ad4a
Support de-deduping head tags by setting key
Oct 25, 2017
8ce3643
move dedupe logic to `unique` function
Oct 25, 2017
7a7385b
fix head tag deduping logic
Oct 26, 2017
500b8ec
remove console.log
Oct 26, 2017
de77b49
use `toContain` assertions
Oct 26, 2017
592d99d
update de-duping head tags section in README
Oct 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/integration/basic/test/rendering.js
View file
Open in desktop
Expand Up @@ -30,12 +30,12 @@ export default function ({ app }, suiteName, render) {

test('header helper dedupes tags', async () => {
const html = await (render('/head'))
expect(html.includes('<meta charSet="iso-8859-5" class="next-head"/>')).toBeTruthy()
expect(html.includes('<meta charSet="utf-8" class="next-head"/>')).toBeFalsy()
expect(html.includes('<meta content="my meta" class="next-head"/>')).toBeTruthy()
expect(html.includes('<link rel="stylesheet" href="/dup-style.css" class="next-head"/><link rel="stylesheet" href="/dup-style.css" class="next-head"/>')).toBeTruthy()
expect(html.includes('<link rel="stylesheet" href="dedupe-style.css" class="next-head"/>')).toBeTruthy()
expect(html.includes('<link rel="stylesheet" href="dedupe-style.css" class="next-head"/><link rel="stylesheet" href="dedupe-style.css" class="next-head"/>')).toBeFalsy()
expect(html).toContain('<meta charSet="iso-8859-5" class="next-head"/>')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.toContain Nice 💯

expect(html).not.toContain('<meta charSet="utf-8" class="next-head"/>')
expect(html).toContain('<meta content="my meta" class="next-head"/>')
expect(html).toContain('<link rel="stylesheet" href="/dup-style.css" class="next-head"/><link rel="stylesheet" href="/dup-style.css" class="next-head"/>')
expect(html).toContain('<link rel="stylesheet" href="dedupe-style.css" class="next-head"/>')
expect(html).not.toContain('<link rel="stylesheet" href="dedupe-style.css" class="next-head"/><link rel="stylesheet" href="dedupe-style.css" class="next-head"/>')
})

test('renders styled jsx', async () => {
Expand Down