Fix wasm loading #31772

padmaia · 2021-11-24T18:59:49Z

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

ijjk · 2021-11-24T19:09:39Z

Failing test suites

Commit: 42dfd1d

test/unit/accept-headers.test.ts

Expand output

● Test suite failed to run

TypeError: bindings.transformAsync is not a function

  129 | export function transformSync(src, options) {
  130 |   let bindings = loadNative()
> 131 |   return bindings.transformAsync(src, options)
      |                   ^
  132 | }
  133 |
  134 | export async function minify(src, options) {

  at Object.transformSync (../packages/next/build/swc/index.js:131:19)
  at Object.process (../packages/next/build/swc/jest-transformer.js:30:40)
  at ScriptTransformer.transformSource (../node_modules/@jest/transform/build/ScriptTransformer.js:612:31)
  at ScriptTransformer._transformAndBuildScript (../node_modules/@jest/transform/build/ScriptTransformer.js:758:40)
  at ScriptTransformer.transform (../node_modules/@jest/transform/build/ScriptTransformer.js:815:19)

test/integration/404-page-ssg/test/index.test.js

Expand output

● Test suite failed to run

TypeError: bindings.transformAsync is not a function

  129 | export function transformSync(src, options) {
  130 |   let bindings = loadNative()
> 131 |   return bindings.transformAsync(src, options)
      |                   ^
  132 | }
  133 |
  134 | export async function minify(src, options) {

  at Object.transformSync (../packages/next/build/swc/index.js:131:19)
  at Object.process (../packages/next/build/swc/jest-transformer.js:30:40)
  at ScriptTransformer.transformSource (../node_modules/@jest/transform/build/ScriptTransformer.js:612:31)
  at ScriptTransformer._transformAndBuildScript (../node_modules/@jest/transform/build/ScriptTransformer.js:758:40)
  at ScriptTransformer.transform (../node_modules/@jest/transform/build/ScriptTransformer.js:815:19)

test/integration/amphtml-custom-optimizer/test/index.test.js

Expand output

● Test suite failed to run

TypeError: bindings.transformAsync is not a function

  129 | export function transformSync(src, options) {
  130 |   let bindings = loadNative()
> 131 |   return bindings.transformAsync(src, options)
      |                   ^
  132 | }
  133 |
  134 | export async function minify(src, options) {

  at Object.transformSync (../packages/next/build/swc/index.js:131:19)
  at Object.process (../packages/next/build/swc/jest-transformer.js:30:40)
  at ScriptTransformer.transformSource (../node_modules/@jest/transform/build/ScriptTransformer.js:612:31)
  at ScriptTransformer._transformAndBuildScript (../node_modules/@jest/transform/build/ScriptTransformer.js:758:40)
  at ScriptTransformer.transform (../node_modules/@jest/transform/build/ScriptTransformer.js:815:19)

test/integration/404-page-custom-error/test/index.test.js

Expand output

● Test suite failed to run

TypeError: bindings.transformAsync is not a function

  129 | export function transformSync(src, options) {
  130 |   let bindings = loadNative()
> 131 |   return bindings.transformAsync(src, options)
      |                   ^
  132 | }
  133 |
  134 | export async function minify(src, options) {

  at Object.transformSync (../packages/next/build/swc/index.js:131:19)
  at Object.process (../packages/next/build/swc/jest-transformer.js:30:40)
  at ScriptTransformer.transformSource (../node_modules/@jest/transform/build/ScriptTransformer.js:612:31)
  at ScriptTransformer._transformAndBuildScript (../node_modules/@jest/transform/build/ScriptTransformer.js:758:40)
  at ScriptTransformer.transform (../node_modules/@jest/transform/build/ScriptTransformer.js:815:19)

test/integration/404-page/test/index.test.js

Expand output

● Test suite failed to run

TypeError: bindings.transformAsync is not a function

  129 | export function transformSync(src, options) {
  130 |   let bindings = loadNative()
> 131 |   return bindings.transformAsync(src, options)
      |                   ^
  132 | }
  133 |
  134 | export async function minify(src, options) {

  at Object.transformSync (../packages/next/build/swc/index.js:131:19)
  at Object.process (../packages/next/build/swc/jest-transformer.js:30:40)
  at ScriptTransformer.transformSource (../node_modules/@jest/transform/build/ScriptTransformer.js:612:31)
  at ScriptTransformer._transformAndBuildScript (../node_modules/@jest/transform/build/ScriptTransformer.js:758:40)
  at ScriptTransformer.transform (../node_modules/@jest/transform/build/ScriptTransformer.js:815:19)

test/integration/amp-export-validation/test/index.test.js

Expand output

● Test suite failed to run

TypeError: bindings.transformAsync is not a function

  129 | export function transformSync(src, options) {
  130 |   let bindings = loadNative()
> 131 |   return bindings.transformAsync(src, options)
      |                   ^
  132 | }
  133 |
  134 | export async function minify(src, options) {

  at Object.transformSync (../packages/next/build/swc/index.js:131:19)
  at Object.process (../packages/next/build/swc/jest-transformer.js:30:40)
  at ScriptTransformer.transformSource (../node_modules/@jest/transform/build/ScriptTransformer.js:612:31)
  at ScriptTransformer._transformAndBuildScript (../node_modules/@jest/transform/build/ScriptTransformer.js:758:40)
  at ScriptTransformer.transform (../node_modules/@jest/transform/build/ScriptTransformer.js:815:19)

test/integration/500-page/test/index.test.js

Expand output

● Test suite failed to run

TypeError: bindings.transformAsync is not a function

  129 | export function transformSync(src, options) {
  130 |   let bindings = loadNative()
> 131 |   return bindings.transformAsync(src, options)
      |                   ^
  132 | }
  133 |
  134 | export async function minify(src, options) {

  at Object.transformSync (../packages/next/build/swc/index.js:131:19)
  at Object.process (../packages/next/build/swc/jest-transformer.js:30:40)
  at ScriptTransformer.transformSource (../node_modules/@jest/transform/build/ScriptTransformer.js:612:31)
  at ScriptTransformer._transformAndBuildScript (../node_modules/@jest/transform/build/ScriptTransformer.js:758:40)
  at ScriptTransformer.transform (../node_modules/@jest/transform/build/ScriptTransformer.js:815:19)

test/production/required-server-files-i18n.test.ts

Expand output

● Test suite failed to run

TypeError: bindings.transformAsync is not a function

  129 | export function transformSync(src, options) {
  130 |   let bindings = loadNative()
> 131 |   return bindings.transformAsync(src, options)
      |                   ^
  132 | }
  133 |
  134 | export async function minify(src, options) {

  at Object.transformSync (../packages/next/build/swc/index.js:131:19)
  at Object.process (../packages/next/build/swc/jest-transformer.js:30:40)
  at ScriptTransformer.transformSource (../node_modules/@jest/transform/build/ScriptTransformer.js:612:31)
  at ScriptTransformer._transformAndBuildScript (../node_modules/@jest/transform/build/ScriptTransformer.js:758:40)
  at ScriptTransformer.transform (../node_modules/@jest/transform/build/ScriptTransformer.js:815:19)

test/development/acceptance/ReactRefresh.test.ts

Expand output

● Test suite failed to run

TypeError: bindings.transformAsync is not a function

  129 | export function transformSync(src, options) {
  130 |   let bindings = loadNative()
> 131 |   return bindings.transformAsync(src, options)
      |                   ^
  132 | }
  133 |
  134 | export async function minify(src, options) {

  at Object.transformSync (../packages/next/build/swc/index.js:131:19)
  at Object.process (../packages/next/build/swc/jest-transformer.js:30:40)
  at ScriptTransformer.transformSource (../node_modules/@jest/transform/build/ScriptTransformer.js:612:31)
  at ScriptTransformer._transformAndBuildScript (../node_modules/@jest/transform/build/ScriptTransformer.js:758:40)
  at ScriptTransformer.transform (../node_modules/@jest/transform/build/ScriptTransformer.js:815:19)

styfle · 2021-11-24T19:16:14Z

packages/next/build/swc/index.js


 const ArchName = arch()
 const PlatformName = platform()
+console.log(ArchName, PlatformName)
+console.log(platformArchTriples)


Should these logs be removed?

ijjk · 2021-11-24T23:03:57Z

Stats from current PR

Default Build

General Overall increase ⚠️

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
buildDuration	22s	22.1s	⚠️ +78ms
buildDurationCached	4.3s	4.5s	⚠️ +242ms
nodeModulesSize	345 MB	345 MB	⚠️ +1.68 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.477	3.65	⚠️ +0.17
/ avg req/sec	719.09	684.91	⚠️ -34.18
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.779	1.731	-0.05
/error-in-render avg req/sec	1405.39	1443.86	+38.47

Client Bundles (main, webpack, commons)

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.4 kB	28.4 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.2 kB	72.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.45 kB	4.45 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
buildDuration	23.4s	24.3s	⚠️ +935ms
buildDurationCached	4.4s	4.3s	-109ms
nodeModulesSize	345 MB	345 MB	⚠️ +1.68 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.461	3.663	⚠️ +0.2
/ avg req/sec	722.39	682.59	⚠️ -39.8
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.901	1.692	-0.21
/error-in-render avg req/sec	1315.44	1477.66	+162.22

Client Bundles (main, webpack, commons)

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.6 kB	28.6 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.5 kB	72.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.47 kB	4.47 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.91 kB	1.91 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.2 kB	13.2 kB	✓

Client Build Manifests

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	padmaia/next.js fix/wasm-loading	Change
index.html gzip	533 B	533 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: 303faa8

padmaia requested review from huozhi, ijjk, shuding, styfle and timneutkens as code owners November 24, 2021 18:59

ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Nov 24, 2021

styfle reviewed Nov 24, 2021

View reviewed changes

Fix wasm loading

53454b2

padmaia force-pushed the fix/wasm-loading branch from 42dfd1d to 53454b2 Compare November 24, 2021 19:16

Remove consoles

7466c76

This comment has been minimized.

Sign in to view

styfle approved these changes Nov 24, 2021

View reviewed changes

Merge branch 'canary' into fix/wasm-loading

303faa8

padmaia merged commit 1bc9b1a into vercel:canary Nov 24, 2021

rtritto mentioned this pull request Nov 25, 2021

Error: Failed to read source code from amp-dev.js #31812

Closed

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix wasm loading #31772

Fix wasm loading #31772

padmaia commented Nov 24, 2021

ijjk commented Nov 24, 2021 •

edited

styfle Nov 24, 2021

This comment has been minimized.

ijjk commented Nov 24, 2021

Fix wasm loading #31772

Fix wasm loading #31772

Conversation

padmaia commented Nov 24, 2021

Bug

Feature

Documentation / Examples

ijjk commented Nov 24, 2021 • edited

Failing test suites

styfle Nov 24, 2021

Choose a reason for hiding this comment

This comment has been minimized.

ijjk commented Nov 24, 2021

Stats from current PR

ijjk commented Nov 24, 2021 •

edited