Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load external binding if local was found #31853

Merged
merged 1 commit into from Nov 26, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Nov 26, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Nov 26, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
buildDuration 21.8s 22s ⚠️ +158ms
buildDurationCached 4s 4s ⚠️ +25ms
nodeModulesSize 346 MB 346 MB ⚠️ +107 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
/ failed reqs 0 0
/ total time (seconds) 3.488 3.515 ⚠️ +0.03
/ avg req/sec 716.8 711.27 ⚠️ -5.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.589 1.598 ⚠️ +0.01
/error-in-render avg req/sec 1573.54 1564.03 ⚠️ -9.51
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.45 kB 4.45 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
buildDuration 23.4s 23.4s -75ms
buildDurationCached 4.1s 4s -80ms
nodeModulesSize 346 MB 346 MB ⚠️ +107 B
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
/ failed reqs 0 0
/ total time (seconds) 3.504 3.537 ⚠️ +0.03
/ avg req/sec 713.51 706.77 ⚠️ -6.74
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.633 1.597 -0.04
/error-in-render avg req/sec 1530.82 1565.59 +34.77
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.47 kB 4.47 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js fix/prefer-local-native Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 0745922

@timneutkens timneutkens merged commit 112ca40 into vercel:canary Nov 26, 2021
@timneutkens timneutkens deleted the fix/prefer-local-native branch November 26, 2021 16:39
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants