Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add .web.jsx extension support in react-native-web example #32076

Merged
merged 2 commits into from
Dec 16, 2021
Merged

fix: add .web.jsx extension support in react-native-web example #32076

merged 2 commits into from
Dec 16, 2021

Conversation

intergalacticspacehighway
Copy link
Contributor

Bug

  • Currently, RNW (react native web) template doesn't support .web.jsx extension. Checkout the screenshot below, where it throws error on importing a file where extension is .web.jsx.

Screenshot 2021-12-03 at 10 34 40 AM

Documentation / Examples

  • Make sure the linting passes by running yarn lint

I think the change is very simple, so I have modified the issue template 馃槄. Let me know if anything is missing!

After this change

  • The import works!

Screenshot 2021-12-03 at 10 38 48 AM

@ijjk ijjk added the examples Issue/PR related to examples label Dec 3, 2021
@ijjk ijjk changed the title fix: add .web.jsx extension support fix: add .web.jsx extension support in react-native-web example Dec 16, 2021
ijjk
ijjk approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk ijjk merged commit 12597f2 into vercel:canary Dec 16, 2021
@intergalacticspacehighway intergalacticspacehighway deleted the fix/RNW-jsx-ext branch December 16, 2021 10:10
@balazsorban44 balazsorban44 mentioned this pull request Dec 24, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@intergalacticspacehighway @ijjk