Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel & next-swc: Fix exporting page config with AsExpression #32702

Merged
merged 7 commits into from Feb 5, 2022

Conversation

hanneslund
Copy link
Member

@hanneslund hanneslund commented Dec 21, 2021

fixes #20626

No changes needed in next-swc, see comments from @kdy1 below.

@ijjk

This comment has been minimized.

@hanneslund hanneslund force-pushed the page-config-asexpression branch from 9481011 to cee2c1b Compare Dec 21, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

Copy link
Member

@kdy1 kdy1 left a comment

Thanks!
I'll look for some other codes related to this PR.

@@ -82,7 +82,15 @@ impl Fold for PageConfig {
}

if is_config {
if let Some(expr) = &decl.init {
let init = decl.init.as_ref().map(|expr| {
Copy link
Member

@kdy1 kdy1 Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is redundant.
We use this pass with swc crate and the swc crate invokes custom passes after stripping typescript types.

And this is a public API, because of the binary size.

Copy link
Member Author

@hanneslund hanneslund Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! I reverted the changes to next-swc.

@ijjk

This comment has been minimized.

ijjk
ijjk approved these changes Feb 5, 2022
Copy link
Member

@ijjk ijjk left a comment

Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Feb 5, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
buildDuration 16.8s 17s ⚠️ +199ms
buildDurationCached 6.5s 6.5s ⚠️ +11ms
nodeModulesSize 359 MB 359 MB ⚠️ +320 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
/ failed reqs 0 0
/ total time (seconds) 3.805 3.747 -0.06
/ avg req/sec 657.08 667.28 +10.2
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.761 1.841 ⚠️ +0.08
/error-in-render avg req/sec 1419.66 1357.81 ⚠️ -61.85
Client Bundles (main, webpack, commons)
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
buildDuration 20.7s 21.4s ⚠️ +723ms
buildDurationCached 6.4s 7.4s ⚠️ +975ms
nodeModulesSize 359 MB 359 MB ⚠️ +320 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
/ failed reqs 0 0
/ total time (seconds) 3.804 3.971 ⚠️ +0.17
/ avg req/sec 657.18 629.59 ⚠️ -27.59
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.767 1.845 ⚠️ +0.08
/error-in-render avg req/sec 1415.04 1354.92 ⚠️ -60.12
Client Bundles (main, webpack, commons)
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary hanneslund/next.js page-config-asexpression Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: d2f0321

@kodiakhq kodiakhq bot merged commit 8aa3620 into vercel:canary Feb 5, 2022
42 checks passed
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
…#32702)

fixes vercel#20626

No changes needed in next-swc, see comments from @kdy1 below.

Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants