Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples): bring with-semantic-ui example up-to-date #32805

Merged
merged 1 commit into from Dec 24, 2021
Merged

fix(examples): bring with-semantic-ui example up-to-date #32805

merged 1 commit into from Dec 24, 2021

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Dec 24, 2021 •
edited

That example was still on Next.js v9

Fixes #30054

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label Dec 24, 2021
@balazsorban44 balazsorban44 changed the title fix(examples): bring example up-to-date fix(examples): bring with-semantic-ui example up-to-date Dec 24, 2021
@balazsorban44 balazsorban44 merged commit 22655a1 into canary Dec 24, 2021
@balazsorban44 balazsorban44 deleted the examples/with-semantic-ui branch December 24, 2021 23:07
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@leerob leerob Awaiting requested review from leerob

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@steven-tey steven-tey Awaiting requested review from steven-tey

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webpack5 not working in with-semantic-ui example
2 participants
@balazsorban44 @ijjk