Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more information under "Caveats" in "src Directory" #33140

Closed
wants to merge 1 commit into from

Conversation

Amila-Rukshan
Copy link

Docs: No info on environment variables in the /src folder #33110
link to the docs => https://nextjs.org/docs/advanced-features/src-directory

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Docs: No info on environment variables in the /src folder vercel#33110
link to the docs => https://nextjs.org/docs/advanced-features/src-directory
@Amila-Rukshan
Copy link
Author

@ijjk, can I have a code review, please?

@atenie
Copy link
Contributor

atenie commented Jan 10, 2022

Hi,

I don't understand why another PR was opened... I made a PR before you that was fixing both files, not just one:

#33136

Kind regards

@Amila-Rukshan Amila-Rukshan deleted the patch-1 branch January 11, 2022 05:42
@vercel vercel locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants