Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-compiled check from copying react-refresh-utils #33442

Merged
merged 3 commits into from
Jan 18, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 18, 2022

This updates to not commit the copied react-refresh-utils files as they will change anytime a new version is published.

Fixes: https://github.com/vercel/next.js/runs/4855748491?check_suite_focus=true

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 18, 2022
@ijjk ijjk marked this pull request as ready for review January 18, 2022 17:07
@ijjk

This comment has been minimized.

huozhi
huozhi previously approved these changes Jan 18, 2022
@ijjk
Copy link
Member Author

ijjk commented Jan 18, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
buildDuration 18.3s 18.1s -145ms
buildDurationCached 3.9s 3.7s -176ms
nodeModulesSize 352 MB 352 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
/ failed reqs 0 0
/ total time (seconds) 3.738 3.929 ⚠️ +0.19
/ avg req/sec 668.84 636.35 ⚠️ -32.49
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.991 1.979 -0.01
/error-in-render avg req/sec 1255.41 1263.29 +7.88
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.7 kB 4.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
buildDuration 19.5s 19.1s -452ms
buildDurationCached 3.8s 3.9s ⚠️ +98ms
nodeModulesSize 352 MB 352 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
/ failed reqs 0 0
/ total time (seconds) 3.892 3.652 -0.24
/ avg req/sec 642.32 684.57 +42.25
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.977 1.937 -0.04
/error-in-render avg req/sec 1264.31 1290.6 +26.29
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/nccing-react-refresh Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 293bc49

@kodiakhq kodiakhq bot merged commit 3220bba into vercel:canary Jan 18, 2022
@ijjk ijjk deleted the update/nccing-react-refresh branch January 18, 2022 18:50
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
This updates to not commit the copied `react-refresh-utils` files as they will change anytime a new version is published. 

Fixes: https://github.com/vercel/next.js/runs/4855748491?check_suite_focus=true
@vercel vercel locked as resolved and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants