Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement abstract methods to get manifest files in the base server #33537

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Jan 21, 2022

Related to #31506, this PR adds getPrerenderManifest and getRoutesManifest methods to provide manifest files to the base server. In the future, we can consider making these methods async, or provide necessary manifests from the very top.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 21, 2022
@shuding shuding mentioned this pull request Jan 21, 2022
15 tasks
huozhi
huozhi previously approved these changes Jan 21, 2022
@ijjk
Copy link
Member

ijjk commented Jan 21, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/504f Change
buildDuration 12s 12s -4ms
buildDurationCached 3.1s 3.1s -30ms
nodeModulesSize 355 MB 355 MB ⚠️ +439 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/504f Change
/ failed reqs 0 0
/ total time (seconds) 2.759 2.748 -0.01
/ avg req/sec 906.18 909.66 +3.48
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.176 1.168 -0.01
/error-in-render avg req/sec 2126.37 2140.12 +13.75
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/504f Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/504f Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/504f Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.87 kB 4.87 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.2 kB 14.2 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/504f Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/504f Change
index.html gzip 531 B 531 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/504f Change
buildDuration 15.7s 15.6s -51ms
buildDurationCached 3.1s 3.1s -56ms
nodeModulesSize 355 MB 355 MB ⚠️ +439 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/504f Change
/ failed reqs 0 0
/ total time (seconds) 2.781 2.746 -0.04
/ avg req/sec 899.05 910.31 +11.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.156 1.156
/error-in-render avg req/sec 2163.56 2162.56 ⚠️ -1
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/504f Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/504f Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/504f Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.89 kB 4.89 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.2 kB 14.2 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/504f Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/504f Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 1ea2af3

@kodiakhq kodiakhq bot merged commit 76b9a54 into vercel:canary Jan 21, 2022
React Server Components in Next.js (Alpha) automation moved this from In review to Done Jan 21, 2022
@shuding shuding deleted the shu/504f branch January 21, 2022 15:33
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
…ercel#33537)

Related to vercel#31506, this PR adds `getPrerenderManifest` and `getRoutesManifest` methods to provide manifest files to the base server. In the future, we can consider making these methods async, or provide necessary manifests from the very top.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants