Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump nft to 0.17.4 #33548

Merged
merged 3 commits into from
Jan 22, 2022
Merged

Bump nft to 0.17.4 #33548

merged 3 commits into from
Jan 22, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented Jan 21, 2022

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 21, 2022
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jan 22, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
buildDuration 12.1s 12.2s ⚠️ +20ms
buildDurationCached 3.2s 3.2s ⚠️ +7ms
nodeModulesSize 355 MB 355 MB ⚠️ +259 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.923 2.943 ⚠️ +0.02
/ avg req/sec 855.17 849.56 ⚠️ -5.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.35 1.326 -0.02
/error-in-render avg req/sec 1851.28 1885.01 +33.73
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71 kB 71 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.87 kB 4.87 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.2 kB 14.2 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
index.html gzip 530 B 530 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
buildDuration 15.5s 15.7s ⚠️ +210ms
buildDurationCached 3.2s 3.3s ⚠️ +140ms
nodeModulesSize 355 MB 355 MB ⚠️ +259 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.937 2.909 -0.03
/ avg req/sec 851.08 859.37 +8.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.343 1.324 -0.02
/error-in-render avg req/sec 1861.49 1888.43 +26.94
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.3 kB 27.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 4.89 kB 4.89 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.2 kB 14.2 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bump-nft-0-17-4 Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 9ac2652

@kodiakhq kodiakhq bot merged commit f81a6a5 into canary Jan 22, 2022
@kodiakhq kodiakhq bot deleted the bump-nft-0-17-4 branch January 22, 2022 00:14
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@styfle @ijjk @natew
Bump nft to 0.17.4 (vercel#33548)
9cc8c4f 
- Fixes vercel#33294

Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@ijjk ijjk ijjk approved these changes

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

esbuild not working in prod serverless functions
3 participants
@styfle @ijjk @huozhi