Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of jscodeshift #34563

Merged
merged 3 commits into from
Feb 18, 2022
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 18, 2022

Bumps the jscodeshift dependency in @next/codemod

x-ref: slack thread

huozhi
huozhi previously approved these changes Feb 18, 2022
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member Author

ijjk commented Feb 18, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/jscodeshift Change
buildDuration 15.8s 15.7s -124ms
buildDurationCached 6.1s 6.1s -28ms
nodeModulesSize 367 MB 367 MB ⚠️ +1.65 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/jscodeshift Change
/ failed reqs 0 0
/ total time (seconds) 3.03 2.978 -0.05
/ avg req/sec 825.18 839.42 +14.24
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.374 1.356 -0.02
/error-in-render avg req/sec 1819.8 1843 +23.2
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/jscodeshift Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/jscodeshift Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/jscodeshift Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/jscodeshift Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/jscodeshift Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/jscodeshift Change
buildDuration 19.2s 19.4s ⚠️ +255ms
buildDurationCached 6.1s 6.2s ⚠️ +141ms
nodeModulesSize 367 MB 367 MB ⚠️ +1.65 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/jscodeshift Change
/ failed reqs 0 0
/ total time (seconds) 3.022 2.996 -0.03
/ avg req/sec 827.32 834.37 +7.05
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.381 1.359 -0.02
/error-in-render avg req/sec 1810.52 1839.42 +28.9
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/jscodeshift Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/jscodeshift Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/jscodeshift Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/jscodeshift Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/jscodeshift Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: dd0286d

@ijjk ijjk merged commit 46d7f45 into vercel:canary Feb 18, 2022
@ijjk ijjk deleted the update/jscodeshift branch February 18, 2022 23:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants