Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match redirect and rewrite destination types #34617

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

balazsorban44
Copy link
Member

Both NextResponse.redirect and NextResponse.rewrite should equally accept a URL as an argument.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Feb 21, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
buildDuration 17.6s 17.3s -230ms
buildDurationCached 7.1s 7s -71ms
nodeModulesSize 367 MB 367 MB ⚠️ +7 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
/ failed reqs 0 0
/ total time (seconds) 3.871 3.642 -0.23
/ avg req/sec 645.84 686.45 +40.61
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.929 1.91 -0.02
/error-in-render avg req/sec 1296.27 1308.68 +12.41
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
buildDuration 21.7s 22s ⚠️ +325ms
buildDurationCached 7s 6.6s -351ms
nodeModulesSize 367 MB 367 MB ⚠️ +7 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
/ failed reqs 0 0
/ total time (seconds) 3.528 3.586 ⚠️ +0.06
/ avg req/sec 708.65 697.15 ⚠️ -11.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.878 1.767 -0.11
/error-in-render avg req/sec 1331.07 1415.19 +84.12
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/middleware-rewrite Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 4392e1c

@ijjk ijjk merged commit 30b434b into canary Feb 21, 2022
@ijjk ijjk deleted the fix/middleware-rewrite branch February 21, 2022 18:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants