Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure rust-check skips on docs only change #34648

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 21, 2022

Follow-up to #34625 this ensures we skip the rust-check job when only a docs change.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Feb 21, 2022
@ijjk
Copy link
Member Author

ijjk commented Feb 21, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
buildDuration 15.1s 15.1s -81ms
buildDurationCached 6s 6s -46ms
nodeModulesSize 367 MB 367 MB ⚠️ +15 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
/ failed reqs 0 0
/ total time (seconds) 2.826 2.79 -0.04
/ avg req/sec 884.55 896.17 +11.62
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.182 1.169 -0.01
/error-in-render avg req/sec 2114.79 2139.05 +24.26
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
buildDuration 18.5s 18.4s -29ms
buildDurationCached 6s 6s ⚠️ +72ms
nodeModulesSize 367 MB 367 MB ⚠️ +15 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
/ failed reqs 0 0
/ total time (seconds) 2.804 2.785 -0.02
/ avg req/sec 891.56 897.53 +5.97
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.185 1.178 -0.01
/error-in-render avg req/sec 2109.88 2121.93 +12.05
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js ci/rustcheck-docs-skip Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 5f2bf17

@ijjk ijjk merged commit 3f9142f into vercel:canary Feb 21, 2022
@ijjk ijjk deleted the ci/rustcheck-docs-skip branch February 21, 2022 19:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants