Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates with-supertokens example #34679

Merged
merged 106 commits into from
Feb 22, 2022
Merged

Updates with-supertokens example #34679

merged 106 commits into from
Feb 22, 2022

Conversation

rishabhpoddar
Copy link
Contributor

Updates supertokens-node dependency to use the latest released version

NkxxkN and others added 30 commits February 16, 2021 15:21
Co-authored-by: Lee Robinson <me@leerob.io>
Co-authored-by: Lee Robinson <me@leerob.io>
Co-authored-by: Lee Robinson <me@leerob.io>
@ijjk ijjk added the examples Issue/PR related to examples label Feb 22, 2022
@rishabhpoddar rishabhpoddar marked this pull request as ready for review February 22, 2022 10:13
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we bump all the dependencies and devDependencies as a house cleaning step?

@rishabhpoddar
Copy link
Contributor Author

@balazsorban44

  • i added a ^ to the react dependency which should fetch the latest version for react anyone installing it now.
  • I updated the dev dependency to the latest version with a ^ too.
  • As for the other dependencies, they all have a ^ anyway and they will fetch the latest versions.

Is this what you wanted?

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let's get rid of devDependencies altogether, as ESLint isn't used in this example.

@rishabhpoddar
Copy link
Contributor Author

Actually, let's get rid of devDependencies altogether, as ESLint isn't used in this example.

Done.

@ijjk ijjk merged commit 037f79d into vercel:canary Feb 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants