[WIP] Support custom regex for excluding modules from Webpack loaders #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to specify a custom regular expression to exclude modules from being handled by JS webpack loaders. The regex can be customized to exclude certain dependencies if transpiling is needed for those modules. (Fixes vercel#706)
Maximilianos
approved these changes
Dec 22, 2017
|
Really nice - and just through exposing an existing API which is currently widely used. |
jamesgorrie
reviewed
Jan 12, 2018
| @@ -1056,6 +1056,26 @@ module.exports = { | |||
|
|
|||
| Note: Next.js will automatically use that prefix in the scripts it loads, but this has no effect whatsoever on `/static`. If you want to serve those assets over the CDN, you'll have to introduce the prefix yourself. One way of introducing a prefix that works inside your components and varies by environment is documented [in this example](https://github.com/zeit/next.js/tree/master/examples/with-universal-configuration). | |||
|
|
|||
| ### Transpile NPM modules | |||
There was a problem hiding this comment.
As this is just exposing the webpack API would the documentation make more sense to say that, and use this as an example of how you might do it?
1 task
|
We're going to add support for transpiling node_modules after v5 is shipped. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to specify a custom regular expression to exclude modules from being handled by JS webpack loaders. The regex can be customized to include certain dependencies if transpiling is needed for those modules. (Possible fix for #706)
Example next.config.js (enables transpiling for files within
node_modules/my-module):