Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ISR error handling #34931

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 1, 2022

This corrects our behavior for when an ISR page is erroring during revalidation as currently Next.js will retry every time a path is requested. This updates to reset the cache period when an error occurs using a max cache extension of 30 seconds and a minimum of 3 seconds.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 1, 2022
@ijjk ijjk requested a review from Timer March 1, 2022 18:16
@ijjk
Copy link
Member Author

ijjk commented Mar 1, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
buildDuration 15.1s 15.1s -20ms
buildDurationCached 6.3s 6.2s -41ms
nodeModulesSize 372 MB 372 MB ⚠️ +748 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
/ failed reqs 0 0
/ total time (seconds) 2.876 2.875 0
/ avg req/sec 869.26 869.7 +0.44
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.167 1.179 ⚠️ +0.01
/error-in-render avg req/sec 2141.39 2119.8 ⚠️ -21.59
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
buildDuration 18.4s 18.2s -222ms
buildDurationCached 6s 6.1s ⚠️ +81ms
nodeModulesSize 372 MB 372 MB ⚠️ +748 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
/ failed reqs 0 0
/ total time (seconds) 2.884 2.888 0
/ avg req/sec 866.8 865.77 ⚠️ -1.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.182 1.152 -0.03
/error-in-render avg req/sec 2115.29 2170.27 +54.98
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.2 kB 5.2 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.9 kB 14.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/isr-error-handling Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: f148dd6

@ijjk ijjk marked this pull request as ready for review March 2, 2022 01:37
@ijjk ijjk merged commit e51d262 into vercel:canary Mar 2, 2022
@ijjk ijjk deleted the update/isr-error-handling branch March 2, 2022 22:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants