Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert server.js to module.exports #35181

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Conversation

ericponto
Copy link
Contributor

@ericponto ericponto commented Mar 9, 2022

If different contexts (using Jest, using Nx, etc), server.js is getting imported when using middleware and throwing the error: "SyntaxError: Unexpected token 'export'".

fixes #32848

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

It seems that when using middleware, server.js is getting imported and throwing the error: "SyntaxError: Unexpected token 'export'"
packages/next/server.js Outdated Show resolved Hide resolved
packages/next/server.js Outdated Show resolved Hide resolved
@ijjk
Copy link
Member

ijjk commented Mar 9, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ericponto/next.js patch-1 Change
buildDuration 15.9s 15.9s -9ms
buildDurationCached 6.3s 6.3s ⚠️ +36ms
nodeModulesSize 372 MB 372 MB ⚠️ +50 B
Page Load Tests Overall increase ✓
vercel/next.js canary ericponto/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.211 3.155 -0.06
/ avg req/sec 778.69 792.43 +13.74
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.445 1.389 -0.06
/error-in-render avg req/sec 1729.8 1799.28 +69.48
Client Bundles (main, webpack)
vercel/next.js canary ericponto/next.js patch-1 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ericponto/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ericponto/next.js patch-1 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.09 kB 5.09 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.8 kB 14.8 kB
Client Build Manifests
vercel/next.js canary ericponto/next.js patch-1 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ericponto/next.js patch-1 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ericponto/next.js patch-1 Change
buildDuration 19.1s 19.1s ⚠️ +85ms
buildDurationCached 6.2s 6.3s ⚠️ +111ms
nodeModulesSize 372 MB 372 MB ⚠️ +50 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ericponto/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.165 3.163 0
/ avg req/sec 789.93 790.48 +0.55
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.413 1.42 ⚠️ +0.01
/error-in-render avg req/sec 1769.44 1760.61 ⚠️ -8.83
Client Bundles (main, webpack)
vercel/next.js canary ericponto/next.js patch-1 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ericponto/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ericponto/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.23 kB 5.23 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15 kB 15 kB
Client Build Manifests
vercel/next.js canary ericponto/next.js patch-1 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ericponto/next.js patch-1 Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 4b342c8

@kodiakhq kodiakhq bot merged commit 8472069 into vercel:canary Mar 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to test middleware with Jest
2 participants