Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update next/image docs for width & height #35188

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Update next/image docs for width & height #35188

merged 7 commits into from
Mar 17, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented Mar 9, 2022

@styfle styfle requested review from kara and atcastle March 9, 2022 22:35
leerob
leerob reviewed Mar 9, 2022
View reviewed changes
docs/basic-features/image-optimization.md Outdated Show resolved Hide resolved
docs/basic-features/image-optimization.md Outdated Show resolved Hide resolved
atcastle
atcastle reviewed Mar 10, 2022
View reviewed changes
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
docs/basic-features/image-optimization.md Outdated Show resolved Hide resolved
@styfle styfle force-pushed the next-image-docs-width-height-improvements branch from 715cda7 to c00a86c Compare March 16, 2022 14:05
@styfle styfle requested review from atcastle and leerob March 16, 2022 14:10
atcastle
atcastle reviewed Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@atcastle atcastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new version seems descriptive and clear. It's going to be basically the same block of text twice in a row, though. Would it make sense to merge these into one "width & height" section, or to just have height say "see width" or something?

@molebox molebox self-requested a review March 17, 2022 13:32
molebox
molebox requested changes Mar 17, 2022
View reviewed changes
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
docs/api-reference/next/image.md Outdated Show resolved Hide resolved
styfle and others added 2 commits March 17, 2022 12:34
@styfle @molebox
Apply suggestions from molebox
85d1c87 
Co-authored-by: Rich Haines <hello@richardhaines.dev>
@styfle
Updates per molebox
6474995
@styfle styfle requested review from atcastle and molebox March 17, 2022 16:40
leerob
leerob previously approved these changes Mar 17, 2022
View reviewed changes
@styfle styfle merged commit bc46022 into canary Mar 17, 2022
@styfle styfle deleted the next-image-docs-width-height-improvements branch March 17, 2022 19:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob left review comments

@kara kara Awaiting requested review from kara

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@atcastle atcastle Awaiting requested review from atcastle

@molebox molebox Awaiting requested review from molebox

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify in Image Optimization docs which width/height to use
5 participants
@styfle @atcastle @leerob @molebox @ijjk