Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Adds try/catch to gracefully handle performance observer exception #35202

Merged
merged 3 commits into from
Mar 10, 2022

Conversation

huzaifarif
Copy link
Contributor

@huzaifarif huzaifarif commented Mar 10, 2022

Handle error thrown in older chrome versions for performanceObserver.observe() when no eventTypes are passed in options.

eventTypes must not be passed when using type and buffered options as per MDN but older browsers like Chrome 69 does not respect this spec.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Mar 10, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
buildDuration 17.5s 17.4s -33ms
buildDurationCached 6.9s 6.9s
nodeModulesSize 372 MB 372 MB ⚠️ +306 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
/ failed reqs 0 0
/ total time (seconds) 3.491 3.476 -0.02
/ avg req/sec 716.1 719.16 +3.06
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.521 1.539 ⚠️ +0.02
/error-in-render avg req/sec 1644.18 1624.88 ⚠️ -19.3
Client Bundles (main, webpack)
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.09 kB 5.09 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.8 kB 14.8 kB
Client Build Manifests
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
buildDuration 20.4s 20.9s ⚠️ +473ms
buildDurationCached 6.8s 6.9s ⚠️ +28ms
nodeModulesSize 372 MB 372 MB ⚠️ +306 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
/ failed reqs 0 0
/ total time (seconds) 3.536 3.554 ⚠️ +0.02
/ avg req/sec 706.91 703.43 ⚠️ -3.48
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.544 1.592 ⚠️ +0.05
/error-in-render avg req/sec 1618.91 1570.61 ⚠️ -48.3
Client Bundles (main, webpack)
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.23 kB 5.23 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15 kB 15 kB
Client Build Manifests
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huzaifarif/next.js fix/35200-performance-observer-error Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: dc60a16

@styfle styfle merged commit ea87415 into vercel:canary Mar 10, 2022
@huzaifarif huzaifarif deleted the fix/35200-performance-observer-error branch March 11, 2022 04:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants