Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: cover re-exported gsp cases for runtime fallback #35326

Merged
merged 3 commits into from
Mar 15, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 15, 2022

Cover re-exported gsp cases from #35011

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@huozhi huozhi force-pushed the enhance/page-runtime-fallback-cases branch from 4ec19fc to 6b1fdeb Compare March 15, 2022 11:59
@ijjk
Copy link
Member

ijjk commented Mar 15, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
buildDuration 18.5s 18.2s -256ms
buildDurationCached 7.1s 7.2s ⚠️ +101ms
nodeModulesSize 456 MB 456 MB ⚠️ +1.39 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
/ failed reqs 0 0
/ total time (seconds) 3.696 3.787 ⚠️ +0.09
/ avg req/sec 676.44 660.12 ⚠️ -16.32
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.618 1.616 0
/error-in-render avg req/sec 1544.73 1547.35 +2.62
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
buildDuration 21.2s 21.3s ⚠️ +134ms
buildDurationCached 7.1s 7s -84ms
nodeModulesSize 456 MB 456 MB ⚠️ +1.39 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
/ failed reqs 0 0
/ total time (seconds) 3.622 3.71 ⚠️ +0.09
/ avg req/sec 690.28 673.78 ⚠️ -16.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.613 1.599 -0.01
/error-in-render avg req/sec 1549.9 1563.4 +13.5
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js enhance/page-runtime-fallback-cases Change
index.html gzip 530 B 530 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 6b1fdeb

@huozhi huozhi requested a review from shuding March 15, 2022 13:12
@kodiakhq kodiakhq bot merged commit 99aea51 into vercel:canary Mar 15, 2022
@huozhi huozhi deleted the enhance/page-runtime-fallback-cases branch March 15, 2022 13:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants