feat(next-swc): embed target triple string #35416

kwonoj · 2022-03-17T21:17:34Z

This PR straightly port over swc's target triple metadata (swc-project/swc#4058) into next-swc, mainly for the tracking purpose of usages.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

ijjk · 2022-03-17T22:38:03Z

Failing test suites

Commit: 2c1346d

yarn testheadless test/production/next/jest/index.test.ts

next/jest > should work

Expand output

● next/jest › should work

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   6 |   let next: NextInstance
   7 |
>  8 |   beforeAll(async () => {
     |   ^
   9 |     next = await createNext({
  10 |       files: {
  11 |         'public/vercel.svg':

  at production/next/jest/index.test.ts:8:3
  at Object.<anonymous> (production/next/jest/index.test.ts:5:1)

● Test suite failed to run

TypeError: Cannot read property 'destroy' of undefined

  134 |     })
  135 |   })
> 136 |   afterAll(() => next.destroy())
      |                       ^
  137 |
  138 |   it('should work', async () => {
  139 |     const html = await renderViaHTTP(next.url, '/')

  at production/next/jest/index.test.ts:136:23

Read more about building and testing Next.js in contributing.md.

padmaia · 2022-03-17T23:23:32Z

packages/next-swc/crates/napi/build.rs

 extern crate napi_build;

 fn main() {
+    let out_dir = env::var("OUT_DIR").expect("Outdir should exist");


Is this being set right now? Would it break the napi-rs builds?

Seems like it is being set by napi-rs, is that correct?

no, it's set by cargo (https://doc.rust-lang.org/cargo/reference/environment-variables.html), as well as other env var in this
build script (TARGET).

OUT_DIR — If the package has a build script, this is set to the folder where the build script should place its output

TARGET — the target triple that is being compiled for. Native code should be compiled for this triple.

These env var should be set as long as build goes through cargo (napi-rs cli wraps cargo as well). If someone uses rustc directly to build package it'll cause compilation error, which is highly unlikely in next-swc's case.

ijjk · 2022-03-18T23:37:44Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
buildDuration	15.2s	15.2s	-82ms
buildDurationCached	6.1s	6.1s	-15ms
nodeModulesSize	456 MB	456 MB	⚠️ +399 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.931	2.977	⚠️ +0.05
/ avg req/sec	853.01	839.79	⚠️ -13.22
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.186	1.164	-0.02
/error-in-render avg req/sec	2108.18	2148.44	+40.26

Client Bundles (main, webpack)

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	28 kB	28 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.6 kB	71.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	192 B	192 B	✓
amp-HASH.js gzip	309 B	309 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.57 kB	2.57 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.48 kB	5.48 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.26 kB	2.26 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.2 kB	15.2 kB	✓

Client Build Manifests

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
buildDuration	18.5s	18.6s	⚠️ +155ms
buildDurationCached	6.1s	6s	-80ms
nodeModulesSize	456 MB	456 MB	⚠️ +399 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.939	2.931	-0.01
/ avg req/sec	850.69	852.93	+2.24
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.181	1.183	0
/error-in-render avg req/sec	2116.59	2113.75	⚠️ -2.84

Client Bundles (main, webpack)

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.2 kB	28.2 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.1 kB	72.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	313 B	313 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	2.56 kB	2.56 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	921 B	921 B	✓
image-HASH.js gzip	5.59 kB	5.59 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.33 kB	2.33 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	388 B	388 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.3 kB	15.3 kB	✓

Client Build Manifests

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	kwonoj/next.js feat-embed-target-triple	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: bb9ad3b

kwonoj requested review from timneutkens, ijjk, shuding, padmaia and huozhi as code owners March 17, 2022 21:17

ijjk added the type: next label Mar 17, 2022

This comment has been minimized.

Sign in to view

kwonoj force-pushed the feat-embed-target-triple branch from 8a17684 to 2c1346d Compare March 17, 2022 22:25

This comment has been minimized.

Sign in to view

kwonoj force-pushed the feat-embed-target-triple branch from 2c1346d to bfaccf0 Compare March 17, 2022 23:11

kwonoj mentioned this pull request Mar 17, 2022

feat(telemetry): report swc target triple to telemetry #35420

Merged

10 tasks

padmaia reviewed Mar 17, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

feat(next-swc): embed target triple string

95570cd

kwonoj force-pushed the feat-embed-target-triple branch from bfaccf0 to 95570cd Compare March 18, 2022 22:09

padmaia approved these changes Mar 18, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'canary' into feat-embed-target-triple

bb9ad3b

ijjk approved these changes Mar 19, 2022

View reviewed changes

kodiakhq bot merged commit 9be56aa into vercel:canary Mar 19, 2022

kwonoj deleted the feat-embed-target-triple branch March 20, 2022 08:40

github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(next-swc): embed target triple string #35416

feat(next-swc): embed target triple string #35416

kwonoj commented Mar 17, 2022

This comment has been minimized.

This comment has been minimized.

ijjk commented Mar 17, 2022

This comment has been minimized.

padmaia Mar 17, 2022

padmaia Mar 17, 2022

kwonoj Mar 18, 2022

This comment has been minimized.

This comment has been minimized.

ijjk commented Mar 18, 2022

feat(next-swc): embed target triple string #35416

feat(next-swc): embed target triple string #35416

Conversation

kwonoj commented Mar 17, 2022

Bug

Feature

Documentation / Examples

This comment has been minimized.

This comment has been minimized.

ijjk commented Mar 17, 2022

Failing test suites

This comment has been minimized.

padmaia Mar 17, 2022

Choose a reason for hiding this comment

padmaia Mar 17, 2022

Choose a reason for hiding this comment

kwonoj Mar 18, 2022

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

ijjk commented Mar 18, 2022

Stats from current PR