Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rsc refresh typing and doc example #35543

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 23, 2022

  • Update typing of useRefreshRoot
  • Make the props argument optional for ts

@ijjk

This comment has been minimized.

Co-authored-by: Shu Ding <g@shud.in>
@huozhi huozhi requested a review from shuding March 23, 2022 11:57
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Mar 24, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
buildDuration 15.9s 15.8s -62ms
buildDurationCached 6.2s 6.9s ⚠️ +719ms
nodeModulesSize 467 MB 467 MB ⚠️ +22 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
/ failed reqs 0 0
/ total time (seconds) 3.169 3.173 0
/ avg req/sec 788.99 787.98 ⚠️ -1.01
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.392 1.394 0
/error-in-render avg req/sec 1796.19 1793.5 ⚠️ -2.69
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Diffs

Diff for main-HASH.js
@@ -3188,7 +3188,7 @@
       exports.useRefreshRoot = useRefreshRoot;
       exports.RefreshContext = void 0;
       var _react = __webpack_require__(7294);
-      var RefreshContext = (0, _react).createContext(function(_) {});
+      var RefreshContext = (0, _react).createContext(function(_props) {});
       exports.RefreshContext = RefreshContext;
       function useRefreshRoot() {
         return (0, _react).useContext(RefreshContext);
Diff for index.html
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-0bf777b4298ee871.js"
+      src="/_next/static/chunks/main-0a8c9a8d191cbfae.js"
       defer=""
     ></script>
     <script
Diff for link.html
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-0bf777b4298ee871.js"
+      src="/_next/static/chunks/main-0a8c9a8d191cbfae.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-0bf777b4298ee871.js"
+      src="/_next/static/chunks/main-0a8c9a8d191cbfae.js"
       defer=""
     ></script>
     <script

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
buildDuration 19.5s 19.7s ⚠️ +254ms
buildDurationCached 6.1s 6.2s ⚠️ +63ms
nodeModulesSize 467 MB 467 MB ⚠️ +22 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
/ failed reqs 0 0
/ total time (seconds) 3.183 3.181 0
/ avg req/sec 785.33 785.88 +0.55
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.957 1.429 -0.53
/error-in-render avg req/sec 1277.45 1749.83 +472.38
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js update-rsc-refresh-doc-typing Change
index.html gzip 531 B 531 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Diffs

Diff for main-HASH.js
@@ -3188,7 +3188,7 @@
       exports.useRefreshRoot = useRefreshRoot;
       exports.RefreshContext = void 0;
       var _react = __webpack_require__(7294);
-      var RefreshContext = (0, _react).createContext(function(_) {});
+      var RefreshContext = (0, _react).createContext(function(_props) {});
       exports.RefreshContext = RefreshContext;
       function useRefreshRoot() {
         return (0, _react).useContext(RefreshContext);
Diff for index.html
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-0bf777b4298ee871.js"
+      src="/_next/static/chunks/main-0a8c9a8d191cbfae.js"
       defer=""
     ></script>
     <script
Diff for link.html
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-0bf777b4298ee871.js"
+      src="/_next/static/chunks/main-0a8c9a8d191cbfae.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-0bf777b4298ee871.js"
+      src="/_next/static/chunks/main-0a8c9a8d191cbfae.js"
       defer=""
     ></script>
     <script
Commit: 5abd6c9

@huozhi huozhi merged commit d5e1225 into vercel:canary Mar 25, 2022
@huozhi huozhi deleted the update-rsc-refresh-doc-typing branch March 25, 2022 21:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants