Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default test timeouts for yarn install times #35669

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 28, 2022

This updates our default test times as discussed to account for longer yarn install times for the isolated tests as GitHub actions network can be slow.

x-ref: #35507 (comment)
x-ref: slack thread

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Mar 28, 2022
@ijjk
Copy link
Member Author

ijjk commented Mar 28, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/test-timeouts Change
buildDuration 17.7s 17.9s ⚠️ +219ms
buildDurationCached 7s 6.9s -77ms
nodeModulesSize 467 MB 467 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/test-timeouts Change
/ failed reqs 0 0
/ total time (seconds) 3.859 3.969 ⚠️ +0.11
/ avg req/sec 647.84 629.9 ⚠️ -17.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.899 1.952 ⚠️ +0.05
/error-in-render avg req/sec 1316.64 1280.68 ⚠️ -35.96
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/test-timeouts Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/test-timeouts Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/test-timeouts Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/test-timeouts Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/test-timeouts Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/test-timeouts Change
buildDuration 21.7s 21.3s -325ms
buildDurationCached 6.8s 6.8s ⚠️ +15ms
nodeModulesSize 467 MB 467 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/test-timeouts Change
/ failed reqs 0 0
/ total time (seconds) 3.788 3.906 ⚠️ +0.12
/ avg req/sec 659.95 640 ⚠️ -19.95
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.853 2.008 ⚠️ +0.16
/error-in-render avg req/sec 1349.14 1244.97 ⚠️ -104.17
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/test-timeouts Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/test-timeouts Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/test-timeouts Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/test-timeouts Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/test-timeouts Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: e4f4d28

@kodiakhq kodiakhq bot merged commit 6a4c70e into vercel:canary Mar 28, 2022
@ijjk ijjk deleted the update/test-timeouts branch March 28, 2022 20:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants