Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Polka server example #3588

Merged
merged 4 commits into from
Jan 31, 2018
Merged

add Polka server example #3588

merged 4 commits into from
Jan 31, 2018

Conversation

mcansh
Copy link
Contributor

@mcansh mcansh commented Jan 18, 2018

sergiodxa
sergiodxa suggested changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@sergiodxa sergiodxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is polka a server with the same API as express?

examples/custom-server-polka/package.json Outdated
"start": "NODE_ENV=production node server.js"
},
"dependencies": {
"next": "4.4.0-canary.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use canary, use latest

examples/custom-server-polka/package.json Outdated
{
"name": "custom-server-polka",
"version": "1.0.0",
"author": "Logan McAnsh <logan@mcan.sh> (https://mcan.sh)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove author, version and name, just scripts and dependencies, keep it simple.

@mcansh
Copy link
Contributor Author

mcansh commented Jan 18, 2018

in a lot of ways, yeah -> https://github.com/lukeed/polka#comparisons

@lukeed
Copy link
Contributor

lukeed commented Jan 24, 2018

Cool! Thanks guys 😃 🎉 I was gunna be adding a with-nextjs example too 😉

@timneutkens
Copy link
Member

@mcansh please run npm run lint -- --fix (or yarn lint --fix) on your branch, then I'll merge 🙏

@timneutkens
Copy link
Member

Actualy I've just ran the lint fixer, will merge when the tests pass. Thanks for your contribution 🙏

@timneutkens timneutkens merged commit 4965387 into vercel:canary Jan 31, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiodxa sergiodxa sergiodxa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcansh @lukeed @timneutkens @sergiodxa